[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rpmorg-maint
Subject:    Re: [Rpm-maint] [rpm-software-management/rpm] don't error out if OpenMP is too old (#1433)
From:       Fabrice Fontaine <notifications () github ! com>
Date:       2020-11-30 20:51:52
Message-ID: rpm-software-management/rpm/pull/1433/c736035545 () github ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


The second point is wrong. If `ENABLE_OPENMP` is not defined and `omp.h` is not \
included, build will still fail on:

```
pack.c: In function 'packageBinaries':
pack.c:769:26: error: expected '#pragma omp' clause before 'priority'
  #pragma omp task untied priority(i)
                          ^
```

Following your first feedback on this PR, I sent a patch to disable openmp on \
buildroot side: https://patchwork.ozlabs.org/project/buildroot/patch/20201112184600.427081-1-fontaine.fabrice@gmail.com/
 I'm still waiting the feedback of the other buildroot members but I think this is \
the only viable option as we can't 'know' the openmp version of every toolchain.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1433#issuecomment-736035545


[Attachment #5 (text/html)]

<p></p>
<p>The second point is wrong. If <code>ENABLE_OPENMP</code> is not defined and \
<code>omp.h</code> is not included, build will still fail on:</p> <pre><code>pack.c: \
In function 'packageBinaries': pack.c:769:26: error: expected '#pragma omp' clause \
before 'priority'  #pragma omp task untied priority(i)
                          ^
</code></pre>
<p>Following your first feedback on this PR, I sent a patch to disable openmp on \
buildroot side: <a href="https://patchwork.ozlabs.org/project/buildroot/patch/20201112184600.427081-1-fontaine.fabrice@gmail.com/" \
rel="nofollow">https://patchwork.ozlabs.org/project/buildroot/patch/20201112184600.427081-1-fontaine.fabrice@gmail.com/</a><br>
 I'm still waiting the feedback of the other buildroot members but I think this is \
the only viable option as we can't 'know' the openmp version of every toolchain.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You \
are receiving this because you are subscribed to this thread.<br />Reply to this \
email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1433#issuecomment-736035545">view \
it on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/ADLPZU6S5R5D2AG3276RGY3SSQAWRANCNFSM4TR2SSQA">unsubscribe</a>.<img \
src="https://github.com/notifications/beacon/ADLPZUZTYWMPXYHZLO6MNHTSSQAWRA5CNFSM4TR2SSQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFPPQFWI.gif" \
height="1" width="1" alt="" /></p> <script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1433#issuecomment-736035545",
 "url": "https://github.com/rpm-software-management/rpm/pull/1433#issuecomment-736035545",
 "name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>



_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[prev in list] [next in list] [prev in thread] [next in thread]