[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rpmorg-maint
Subject:    [Rpm-maint] [PATCH 1/3] rpmrc: do not use that nonexistent rpmOptionValue struct.
From:       pmatilai () laiskiainen ! org (Panu Matilainen)
Date:       2012-01-04 9:07:57
Message-ID: 4F0416ED.4020702 () laiskiainen ! org
[Download RAW message or body]

On 01/03/2012 05:20 PM, Ales Kozumplik wrote:
> On 01/03/2012 04:18 PM, Ales Kozumplik wrote:
>> ---
>> lib/rpmrc.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/lib/rpmrc.c b/lib/rpmrc.c
>> index 1c4ebb4..177db0e 100644
>> --- a/lib/rpmrc.c
>> +++ b/lib/rpmrc.c
>> @@ -72,7 +72,6 @@ struct rpmOption {
>> int required;
>> int macroize;
>> int localize;
>> -struct rpmOptionValue * value;
>> };
>>
>> typedef struct defaultEntry_s {
>
> I am not sure if this even deserves review but then again: it seems so
> weird for this to be surviving in the code that I might as well have
> missed something.

Heh, there are all sorts of ancient creatures in various stages of 
"life" (ranging all the way from unborn to undead) lurking in dark 
corners of the rpm codebase, some more harmless than others. This baby 
here looks like its one of those unborn thingies, AFAICS struct 
rpmOptionValue has never been even defined, never mind used.

Feel free to kick it out, ditto for the "required" thing.

	- Panu -

[prev in list] [next in list] [prev in thread] [next in thread]