[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rpmorg-maint
Subject:    [Rpm-maint] [Suse patch] Use lstat for symlink globbing
From:       pmatilai () redhat ! com (Panu Matilainen)
Date:       2007-05-25 9:18:41
Message-ID: Pine.LNX.4.64.0705251152310.19155 () dhcp115 ! koti ! laiskiainen ! org
[Download RAW message or body]


The rpm.org tree always uses the internal glob implementation as well so 
this isn't needed AFAICT. Post 4.4.2.1 I'd like to get rid of those 
internal implementations of historical as much as possible though...

 	- Panu -

---

Always use lstat in glob call to work around a change in glibc's
glob code. [#129434], rh#126460

rpm-4.4.7 comes with its own glob implementation, so it doesn't
need this patch (but it also doesn't hurt).

--- ./rpmio/rpmrpc.c.orig	2005-12-16 15:01:26.000000000 +0000
+++ ./rpmio/rpmrpc.c	2006-02-13 18:55:39.000000000 +0000
@@ -1450,7 +1462,8 @@ fprintf(stderr, "*** Glob(%s,0x%x,%p,%p)
  	pglob->gl_readdir = Readdir;
  	pglob->gl_opendir = Opendir;
  	pglob->gl_lstat = Lstat;
-	pglob->gl_stat = Stat;
+	/* always use lstat to glob symlinks */
+	pglob->gl_stat = Lstat;
  /*@=type@*/
  	flags |= GLOB_ALTDIRFUNC;
  	flags &= ~GLOB_TILDE;


[prev in list] [next in list] [prev in thread] [next in thread]