[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rpm-devel
Subject:    Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ depends.c
From:       Jeff Johnson <n3npq () mac ! com>
Date:       2008-01-31 20:07:53
Message-ID: BF94E685-B2B0-4472-A824-F2272484F89A () mac ! com
[Download RAW message or body]


On Jan 31, 2008, at 2:41 PM, Ralf S. Engelschall wrote:

> On Thu, Jan 31, 2008, Jeff Johnson wrote:
>
>>
>>
>> Equivalently, you could do your comparison against INSTALLTID  
>> rather than
>> INSTALLTIME.
>
> Sure, but INSTALLTIME is what people usually look at and if I print
> ORIGINTIME (usually in "rpm -qi" output) there can be this time offset
> which people might find confusing as they previously got told that
> ORIGINTIME is the INSTALLTIME of the initially installed package
> version...
>

And the counter response is that rpm -qa --last will not reflect
the order that packages were installed.

> So, I still think the best is to exactly synchronize ORIGINTIME
> with INSTALLTIME on the value initialization and this way avoid any
> confusion:
>
> Index: lib/psm.c
> ===================================================================
> RCS file: /v/rpm/cvs/rpm/lib/psm.c,v
> retrieving revision 2.282
> diff -u -d -u -d -r2.282 psm.c
> --- lib/psm.c	31 Jan 2008 07:26:12 -0000	2.282
> +++ lib/psm.c	31 Jan 2008 19:06:43 -0000
> @@ -1572,7 +1572,7 @@
>
>      /* Propagate the time that the package was first installed. */
>      if (originTime == 0)
> -	originTime = rpmtsGetTid(ts);
> +	originTime = installTime;
>      he->tag = RPMTAG_ORIGINTIME;
>      he->t = RPM_UINT32_TYPE;
>      he->p.ui32p = &originTime;
>
> But I'm also fine with this change:
>
> Index: lib/psm.c
> ===================================================================
> RCS file: /v/rpm/cvs/rpm/lib/psm.c,v
> retrieving revision 2.282
> diff -u -d -u -d -r2.282 psm.c
> --- lib/psm.c	31 Jan 2008 07:26:12 -0000	2.282
> +++ lib/psm.c	31 Jan 2008 19:41:49 -0000
> @@ -1572,7 +1572,11 @@
>
>      /* Propagate the time that the package was first installed. */
>      if (originTime == 0)
> +#if defined(RPM_VENDOR_OPENPKG) /* avoid-initial-offset-between- 
> origintime-and-installtime */
> +	originTime = installTime;
> +#else
>  	originTime = rpmtsGetTid(ts);
> +#endif
>      he->tag = RPMTAG_ORIGINTIME;
>      he->t = RPM_UINT32_TYPE;
>      he->p.ui32p = &originTime;
>
> So, which one of the three possible changes do _you_ prefer, Jeff?
>

I prefer sexagesimal arithmetic coded in Brainfuck with output in a  
Babylonian locale ...

Alternatively, a higher precision timestamp, time(2) is showing its  
age ...

73 de Jeff
______________________________________________________________________
RPM Package Manager                                    http://rpm5.org
Developer Communication List                        rpm-devel@rpm5.org
[prev in list] [next in list] [prev in thread] [next in thread]