[prev in list] [next in list] [prev in thread] [next in thread]
List: ros-diffs
Subject: [ros-diffs] [ekohl] 13763: - Data is now written to the readers
From: <ekohl () svn ! reactos ! com>
Date: 2005-02-27 12:43:39
Message-ID: 000001c51cc9$f601e250$6601a8c0 () penelope
[Download RAW message or body]
- Data is now written to the readers data buffer and the reader reads
from his own data buffer. This fixes Filip's wrokaround to enable the
reader to read data although the writers side was closed.
- Minor cleanup.
Modified: trunk/reactos/drivers/fs/np/create.c
Modified: trunk/reactos/drivers/fs/np/finfo.c
Modified: trunk/reactos/drivers/fs/np/fsctrl.c
Modified: trunk/reactos/drivers/fs/np/npfs.c
Modified: trunk/reactos/drivers/fs/np/npfs.h
Modified: trunk/reactos/drivers/fs/np/rw.c
Modified: trunk/reactos/drivers/fs/np/volume.c
_____
Modified: trunk/reactos/drivers/fs/np/create.c
--- trunk/reactos/drivers/fs/np/create.c 2005-02-26 23:22:48 UTC
(rev 13762)
+++ trunk/reactos/drivers/fs/np/create.c 2005-02-27 12:43:37 UTC
(rev 13763)
@@ -2,7 +2,7 @@
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
- * FILE: services/fs/np/create.c
+ * FILE: drivers/fs/np/create.c
* PURPOSE: Named pipe filesystem
* PROGRAMMER: David Welch <welch@cwcom.net>
*/
@@ -164,9 +164,9 @@
ClientFcb->PipeState = SpecialAccess ? 0 :
FILE_PIPE_DISCONNECTED_STATE;
/* Initialize data list. */
- if (Pipe->InboundQuota)
+ if (Pipe->OutboundQuota)
{
- ClientFcb->Data = ExAllocatePool(NonPagedPool,
Pipe->InboundQuota);
+ ClientFcb->Data = ExAllocatePool(NonPagedPool,
Pipe->OutboundQuota);
if (ClientFcb->Data == NULL)
{
DPRINT("No memory!\n");
@@ -185,8 +185,8 @@
ClientFcb->ReadPtr = ClientFcb->Data;
ClientFcb->WritePtr = ClientFcb->Data;
ClientFcb->ReadDataAvailable = 0;
- ClientFcb->WriteQuotaAvailable = Pipe->InboundQuota;
- ClientFcb->MaxDataLength = Pipe->InboundQuota;
+ ClientFcb->WriteQuotaAvailable = Pipe->OutboundQuota;
+ ClientFcb->MaxDataLength = Pipe->OutboundQuota;
KeInitializeSpinLock(&ClientFcb->DataListLock);
KeInitializeEvent(&ClientFcb->ConnectEvent, SynchronizationEvent,
FALSE);
KeInitializeEvent(&ClientFcb->Event, SynchronizationEvent, FALSE);
@@ -381,9 +381,9 @@
KeUnlockMutex(&DeviceExt->PipeListLock);
}
- if (Pipe->OutboundQuota)
+ if (Pipe->InboundQuota)
{
- Fcb->Data = ExAllocatePool(NonPagedPool, Pipe->OutboundQuota);
+ Fcb->Data = ExAllocatePool(NonPagedPool, Pipe->InboundQuota);
if (Fcb->Data == NULL)
{
ExFreePool(Fcb);
@@ -407,8 +407,8 @@
Fcb->ReadPtr = Fcb->Data;
Fcb->WritePtr = Fcb->Data;
Fcb->ReadDataAvailable = 0;
- Fcb->WriteQuotaAvailable = Pipe->OutboundQuota;
- Fcb->MaxDataLength = Pipe->OutboundQuota;
+ Fcb->WriteQuotaAvailable = Pipe->InboundQuota;
+ Fcb->MaxDataLength = Pipe->InboundQuota;
KeInitializeSpinLock(&Fcb->DataListLock);
Pipe->CurrentInstances++;
@@ -442,9 +442,8 @@
NTSTATUS STDCALL
-NpfsClose(
- PDEVICE_OBJECT DeviceObject,
- PIRP Irp)
+NpfsClose(PDEVICE_OBJECT DeviceObject,
+ PIRP Irp)
{
PNPFS_DEVICE_EXTENSION DeviceExt;
PIO_STACK_LOCATION IoStack;
@@ -493,10 +492,8 @@
{
if (Fcb->OtherSide)
{
-#ifndef FIN_WORKAROUND_READCLOSE
Fcb->OtherSide->PipeState = FILE_PIPE_CLOSING_STATE;
Fcb->OtherSide->OtherSide = NULL;
-#endif
/*
* Signaling the write event. If is possible that an other
* thread waits for an empty buffer.
@@ -504,40 +501,16 @@
KeSetEvent(&Fcb->OtherSide->Event, IO_NO_INCREMENT, FALSE);
}
-#ifndef FIN_WORKAROUND_READCLOSE
Fcb->PipeState = 0;
-#endif
}
FileObject->FsContext = NULL;
-#ifndef FIN_WORKAROUND_READCLOSE
RemoveEntryList(&Fcb->FcbListEntry);
if (Fcb->Data)
ExFreePool(Fcb->Data);
ExFreePool(Fcb);
-#else
- Fcb->PipeState = FILE_PIPE_CLOSING_STATE;
- if (Fcb->OtherSide == NULL ||
- Fcb->OtherSide->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- if (Server && Fcb->OtherSide != NULL &&
- Fcb->OtherSide->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- RemoveEntryList(&Fcb->OtherSide->FcbListEntry);
- if (Fcb->OtherSide->Data)
- ExFreePool(Fcb->OtherSide->Data);
- ExFreePool(Fcb->OtherSide);
- }
- RemoveEntryList(&Fcb->FcbListEntry);
- if (Fcb->Data)
- ExFreePool(Fcb->Data);
-
- ExFreePool(Fcb);
- }
-#endif
-
KeUnlockMutex(&Pipe->FcbListLock);
if (IsListEmpty(&Pipe->ServerFcbListHead) &&
_____
Modified: trunk/reactos/drivers/fs/np/finfo.c
--- trunk/reactos/drivers/fs/np/finfo.c 2005-02-26 23:22:48 UTC (rev
13762)
+++ trunk/reactos/drivers/fs/np/finfo.c 2005-02-27 12:43:37 UTC (rev
13763)
@@ -2,9 +2,9 @@
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
- * FILE: services/fs/np/finfo.c
+ * FILE: drivers/fs/np/finfo.c
* PURPOSE: Named pipe filesystem
- * PROGRAMMER: Eric Kohl <ekohl@rz-online.de>
+ * PROGRAMMER: Eric Kohl
*/
/* INCLUDES
******************************************************************/
@@ -36,7 +36,7 @@
// Info->CompletionMode =
*BufferLength -= sizeof(FILE_PIPE_INFORMATION);
- return(STATUS_SUCCESS);
+ return STATUS_SUCCESS;
}
@@ -76,7 +76,7 @@
}
*BufferLength -= sizeof(FILE_PIPE_LOCAL_INFORMATION);
- return(STATUS_SUCCESS);
+ return STATUS_SUCCESS;
}
@@ -93,24 +93,24 @@
PVOID SystemBuffer;
ULONG BufferLength;
NTSTATUS Status;
-
+
DPRINT("NpfsQueryInformation(DeviceObject %p Irp %p)\n",
DeviceObject, Irp);
-
+
IoStack = IoGetCurrentIrpStackLocation (Irp);
FileInformationClass =
IoStack->Parameters.QueryFile.FileInformationClass;
DeviceExtension = DeviceObject->DeviceExtension;
FileObject = IoStack->FileObject;
Fcb = (PNPFS_FCB)FileObject->FsContext;
Pipe = Fcb->Pipe;
-
+
SystemBuffer = Irp->AssociatedIrp.SystemBuffer;
BufferLength = IoStack->Parameters.QueryFile.Length;
-
+
DPRINT("Pipe name: %wZ\n", &Pipe->PipeName);
DPRINT("FileInformationClass %d\n", FileInformationClass);
DPRINT("SystemBuffer %p\n", SystemBuffer);
DPRINT("BufferLength %lu\n", BufferLength);
-
+
switch (FileInformationClass)
{
case FilePipeInformation:
@@ -134,7 +134,7 @@
default:
Status = STATUS_NOT_SUPPORTED;
}
-
+
Irp->IoStatus.Status = Status;
if (NT_SUCCESS(Status))
Irp->IoStatus.Information =
@@ -142,8 +142,8 @@
else
Irp->IoStatus.Information = 0;
IoCompleteRequest (Irp, IO_NO_INCREMENT);
-
- return(Status);
+
+ return Status;
}
@@ -196,7 +196,7 @@
IoCompleteRequest(Irp,
IO_NO_INCREMENT);
- return(Status);
+ return Status;
}
/* EOF */
_____
Modified: trunk/reactos/drivers/fs/np/fsctrl.c
--- trunk/reactos/drivers/fs/np/fsctrl.c 2005-02-26 23:22:48 UTC
(rev 13762)
+++ trunk/reactos/drivers/fs/np/fsctrl.c 2005-02-27 12:43:37 UTC
(rev 13763)
@@ -2,10 +2,10 @@
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
- * FILE: services/fs/np/fsctrl.c
+ * FILE: drivers/fs/np/fsctrl.c
* PURPOSE: Named pipe filesystem
* PROGRAMMER: David Welch <welch@cwcom.net>
- * Eric Kohl <ekohl@rz-online.de>
+ * Eric Kohl
*/
/* INCLUDES
******************************************************************/
_____
Modified: trunk/reactos/drivers/fs/np/npfs.c
--- trunk/reactos/drivers/fs/np/npfs.c 2005-02-26 23:22:48 UTC (rev
13762)
+++ trunk/reactos/drivers/fs/np/npfs.c 2005-02-27 12:43:37 UTC (rev
13763)
@@ -2,7 +2,7 @@
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
- * FILE: services/fs/np/mount.c
+ * FILE: drivers/fs/np/mount.c
* PURPOSE: Named pipe filesystem
* PROGRAMMER: David Welch <welch@cwcom.net>
*/
@@ -64,7 +64,7 @@
if (!NT_SUCCESS(Status))
{
DPRINT("Failed to create named pipe device! (Status %x)\n",
Status);
- return(Status);
+ return Status;
}
/* initialize the device object */
@@ -81,7 +81,7 @@
DeviceExtension->DefaultQuota = 8 * PAGE_SIZE;
DeviceExtension->MaxQuota = 64 * PAGE_SIZE;
- return(STATUS_SUCCESS);
+ return STATUS_SUCCESS;
}
/* EOF */
_____
Modified: trunk/reactos/drivers/fs/np/npfs.h
--- trunk/reactos/drivers/fs/np/npfs.h 2005-02-26 23:22:48 UTC (rev
13762)
+++ trunk/reactos/drivers/fs/np/npfs.h 2005-02-27 12:43:37 UTC (rev
13763)
@@ -1,14 +1,8 @@
/* $Id$ */
-#ifndef __SERVICES_FS_NP_NPFS_H
-#define __SERVICES_FS_NP_NPFS_H
+#ifndef __DRIVERS_FS_NP_NPFS_H
+#define __DRIVERS_FS_NP_NPFS_H
-/*
- * Hacky support for delayed closing of pipes. We need this to support
- * reading from pipe the was closed on one end.
- */
-#define FIN_WORKAROUND_READCLOSE
-
typedef struct _NPFS_DEVICE_EXTENSION
{
LIST_ENTRY PipeListHead;
@@ -70,9 +64,7 @@
#define KeUnlockMutex(x) KeReleaseMutex(x, FALSE);
-#define CP DPRINT("\n");
-
NTSTATUS STDCALL NpfsCreate(PDEVICE_OBJECT DeviceObject, PIRP Irp);
NTSTATUS STDCALL NpfsCreateNamedPipe(PDEVICE_OBJECT DeviceObject, PIRP
Irp);
NTSTATUS STDCALL NpfsClose(PDEVICE_OBJECT DeviceObject, PIRP Irp);
@@ -89,4 +81,4 @@
NTSTATUS STDCALL NpfsQueryVolumeInformation (PDEVICE_OBJECT
DeviceObject, PIRP Irp);
-#endif /* __SERVICES_FS_NP_NPFS_H */
+#endif /* __DRIVERS_FS_NP_NPFS_H */
_____
Modified: trunk/reactos/drivers/fs/np/rw.c
--- trunk/reactos/drivers/fs/np/rw.c 2005-02-26 23:22:48 UTC (rev
13762)
+++ trunk/reactos/drivers/fs/np/rw.c 2005-02-27 12:43:37 UTC (rev
13763)
@@ -2,7 +2,7 @@
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
- * FILE: services/fs/np/rw.c
+ * FILE: drivers/fs/np/rw.c
* PURPOSE: Named pipe filesystem
* PROGRAMMER: David Welch <welch@cwcom.net>
*/
@@ -16,8 +16,6 @@
#define NDEBUG
#include <debug.h>
-#define FIN_WORKAROUND_READCLOSE
-
/* FUNCTIONS
*****************************************************************/
#ifndef NDEBUG
@@ -60,7 +58,7 @@
KIRQL OldIrql;
ULONG Information;
PNPFS_FCB Fcb;
- PNPFS_FCB ReadFcb;
+ PNPFS_FCB WriterFcb;
PNPFS_PIPE Pipe;
ULONG Length;
PVOID Buffer;
@@ -74,22 +72,8 @@
FileObject = IoStack->FileObject;
Fcb = FileObject->FsContext;
Pipe = Fcb->Pipe;
- ReadFcb = Fcb->OtherSide;
+ WriterFcb = Fcb->OtherSide;
- if (ReadFcb == NULL)
- {
- DPRINT("Pipe is NOT connected!\n");
- if (Fcb->PipeState == FILE_PIPE_LISTENING_STATE)
- Status = STATUS_PIPE_LISTENING;
- else if (Fcb->PipeState == FILE_PIPE_DISCONNECTED_STATE)
- Status = STATUS_PIPE_DISCONNECTED;
- else
- Status = STATUS_PIPE_BROKEN;
- Information = 0;
- DPRINT("%x\n", Status);
- goto done;
- }
-
if (Irp->MdlAddress == NULL)
{
DPRINT("Irp->MdlAddress == NULL\n");
@@ -98,7 +82,7 @@
goto done;
}
- if (ReadFcb->Data == NULL)
+ if (Fcb->Data == NULL)
{
DPRINT("Pipe is NOT readable!\n");
Status = STATUS_UNSUCCESSFUL;
@@ -106,31 +90,20 @@
goto done;
}
-#ifdef FIN_WORKAROUND_READCLOSE
- if (ReadFcb->ReadDataAvailable == 0 &&
- ReadFcb->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- DPRINT("Other end of pipe is closed!\n");
- Status = STATUS_PIPE_BROKEN;
- Information = 0;
- goto done;
- }
-#endif
-
Status = STATUS_SUCCESS;
Length = IoStack->Parameters.Read.Length;
Information = 0;
Buffer = MmGetSystemAddressForMdl(Irp->MdlAddress);
- KeAcquireSpinLock(&ReadFcb->DataListLock, &OldIrql);
+ KeAcquireSpinLock(&Fcb->DataListLock, &OldIrql);
while (1)
{
/* FIXME: check if in blocking mode */
- if (ReadFcb->ReadDataAvailable == 0)
+ if (Fcb->ReadDataAvailable == 0)
{
KeResetEvent(&Fcb->Event);
- KeSetEvent(&ReadFcb->Event, IO_NO_INCREMENT, FALSE);
- KeReleaseSpinLock(&ReadFcb->DataListLock, OldIrql);
+ KeSetEvent(&WriterFcb->Event, IO_NO_INCREMENT, FALSE);
+ KeReleaseSpinLock(&Fcb->DataListLock, OldIrql);
if (Information > 0)
{
Status = STATUS_SUCCESS;
@@ -153,56 +126,44 @@
NULL);
DPRINT("Finished waiting (%S)! Status: %x\n",
Pipe->PipeName.Buffer, Status);
-#ifndef FIN_WORKAROUND_READCLOSE
- /*
- * It's possible that the event was signaled because the
- * other side of pipe was closed.
- */
- if (Fcb->PipeState != FILE_PIPE_CONNECTED_STATE)
- {
- DPRINT("PipeState: %x\n", Fcb->PipeState);
- Status = STATUS_PIPE_BROKEN;
- goto done;
- }
-#endif
- KeAcquireSpinLock(&ReadFcb->DataListLock, &OldIrql);
+ KeAcquireSpinLock(&Fcb->DataListLock, &OldIrql);
}
if (Pipe->ReadMode == FILE_PIPE_BYTE_STREAM_MODE)
{
DPRINT("Byte stream mode\n");
/* Byte stream mode */
- while (Length > 0 && ReadFcb->ReadDataAvailable > 0)
+ while (Length > 0 && Fcb->ReadDataAvailable > 0)
{
- CopyLength = RtlRosMin(ReadFcb->ReadDataAvailable,
Length);
- if (ReadFcb->ReadPtr + CopyLength <= ReadFcb->Data +
ReadFcb->MaxDataLength)
+ CopyLength = RtlRosMin(Fcb->ReadDataAvailable, Length);
+ if (Fcb->ReadPtr + CopyLength <= Fcb->Data +
Fcb->MaxDataLength)
{
- memcpy(Buffer, ReadFcb->ReadPtr, CopyLength);
- ReadFcb->ReadPtr += CopyLength;
- if (ReadFcb->ReadPtr == ReadFcb->Data +
ReadFcb->MaxDataLength)
+ memcpy(Buffer, Fcb->ReadPtr, CopyLength);
+ Fcb->ReadPtr += CopyLength;
+ if (Fcb->ReadPtr == Fcb->Data + Fcb->MaxDataLength)
{
- ReadFcb->ReadPtr = ReadFcb->Data;
+ Fcb->ReadPtr = Fcb->Data;
}
}
else
{
- TempLength = ReadFcb->Data + ReadFcb->MaxDataLength -
ReadFcb->ReadPtr;
- memcpy(Buffer, ReadFcb->ReadPtr, TempLength);
- memcpy(Buffer + TempLength, ReadFcb->Data, CopyLength
- TempLength);
- ReadFcb->ReadPtr = ReadFcb->Data + CopyLength -
TempLength;
+ TempLength = Fcb->Data + Fcb->MaxDataLength -
Fcb->ReadPtr;
+ memcpy(Buffer, Fcb->ReadPtr, TempLength);
+ memcpy(Buffer + TempLength, Fcb->Data, CopyLength -
TempLength);
+ Fcb->ReadPtr = Fcb->Data + CopyLength - TempLength;
}
Buffer += CopyLength;
Length -= CopyLength;
Information += CopyLength;
- ReadFcb->ReadDataAvailable -= CopyLength;
- ReadFcb->WriteQuotaAvailable += CopyLength;
+ Fcb->ReadDataAvailable -= CopyLength;
+ Fcb->WriteQuotaAvailable += CopyLength;
}
if (Length == 0)
{
- KeSetEvent(&ReadFcb->Event, IO_NO_INCREMENT, FALSE);
+ KeSetEvent(&WriterFcb->Event, IO_NO_INCREMENT, FALSE);
break;
}
}
@@ -211,11 +172,11 @@
DPRINT("Message mode\n");
/* Message mode */
- if (ReadFcb->ReadDataAvailable)
+ if (Fcb->ReadDataAvailable)
{
/* Truncate the message if the receive buffer is too small
*/
- CopyLength = RtlRosMin(ReadFcb->ReadDataAvailable,
Length);
- memcpy(Buffer, ReadFcb->Data, CopyLength);
+ CopyLength = RtlRosMin(Fcb->ReadDataAvailable, Length);
+ memcpy(Buffer, Fcb->Data, CopyLength);
#ifndef NDEBUG
DPRINT("Length %d Buffer %x\n",CopyLength,Buffer);
@@ -223,28 +184,19 @@
#endif
Information = CopyLength;
- ReadFcb->ReadDataAvailable = 0;
- ReadFcb->WriteQuotaAvailable = ReadFcb->MaxDataLength;
+ Fcb->ReadDataAvailable = 0;
+ Fcb->WriteQuotaAvailable = Fcb->MaxDataLength;
}
if (Information > 0)
{
- KeSetEvent(&ReadFcb->Event, IO_NO_INCREMENT, FALSE);
+ KeSetEvent(&WriterFcb->Event, IO_NO_INCREMENT, FALSE);
break;
}
}
-
-#ifdef FIN_WORKAROUND_READCLOSE
- if (ReadFcb->ReadDataAvailable == 0 &&
- ReadFcb->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- DPRINT("Other end of pipe is closed!\n");
- break;
- }
-#endif
}
- KeReleaseSpinLock(&ReadFcb->DataListLock, OldIrql);
+ KeReleaseSpinLock(&Fcb->DataListLock, OldIrql);
done:
Irp->IoStatus.Status = Status;
@@ -265,6 +217,7 @@
PIO_STACK_LOCATION IoStack;
PFILE_OBJECT FileObject;
PNPFS_FCB Fcb = NULL;
+ PNPFS_FCB ReaderFcb;
PNPFS_PIPE Pipe = NULL;
PUCHAR Buffer;
NTSTATUS Status = STATUS_SUCCESS;
@@ -283,6 +236,7 @@
DPRINT("Pipe name %wZ\n", &FileObject->FileName);
Fcb = FileObject->FsContext;
+ ReaderFcb = Fcb->OtherSide;
Pipe = Fcb->Pipe;
Length = IoStack->Parameters.Write.Length;
@@ -297,7 +251,7 @@
goto done;
}
- if (Fcb->OtherSide == NULL)
+ if (ReaderFcb == NULL)
{
DPRINT("Pipe is NOT connected!\n");
if (Fcb->PipeState == FILE_PIPE_LISTENING_STATE)
@@ -310,7 +264,7 @@
goto done;
}
- if (Fcb->Data == NULL)
+ if (ReaderFcb->Data == NULL)
{
DPRINT("Pipe is NOT writable!\n");
Status = STATUS_UNSUCCESSFUL;
@@ -321,7 +275,7 @@
Status = STATUS_SUCCESS;
Buffer = MmGetSystemAddressForMdl (Irp->MdlAddress);
- KeAcquireSpinLock(&Fcb->DataListLock, &OldIrql);
+ KeAcquireSpinLock(&ReaderFcb->DataListLock, &OldIrql);
#ifndef NDEBUG
DPRINT("Length %d Buffer %x Offset %x\n",Length,Buffer,Offset);
HexDump(Buffer, Length);
@@ -329,11 +283,11 @@
while(1)
{
- if (Fcb->WriteQuotaAvailable == 0)
+ if (ReaderFcb->WriteQuotaAvailable == 0)
{
KeResetEvent(&Fcb->Event);
- KeSetEvent(&Fcb->OtherSide->Event, IO_NO_INCREMENT, FALSE);
- KeReleaseSpinLock(&Fcb->DataListLock, OldIrql);
+ KeSetEvent(&ReaderFcb->Event, IO_NO_INCREMENT, FALSE);
+ KeReleaseSpinLock(&ReaderFcb->DataListLock, OldIrql);
if (Fcb->PipeState != FILE_PIPE_CONNECTED_STATE)
{
Status = STATUS_PIPE_BROKEN;
@@ -348,7 +302,6 @@
NULL);
DPRINT("Finished waiting (%S)! Status: %x\n",
Pipe->PipeName.Buffer, Status);
-#ifndef FIN_WORKAROUND_READCLOSE
/*
* It's possible that the event was signaled because the
* other side of pipe was closed.
@@ -359,44 +312,43 @@
Status = STATUS_PIPE_BROKEN;
goto done;
}
-#endif
- KeAcquireSpinLock(&Fcb->DataListLock, &OldIrql);
+ KeAcquireSpinLock(&ReaderFcb->DataListLock, &OldIrql);
}
if (Pipe->WriteMode == FILE_PIPE_BYTE_STREAM_MODE)
{
DPRINT("Byte stream mode\n");
- while (Length > 0 && Fcb->WriteQuotaAvailable > 0)
+ while (Length > 0 && ReaderFcb->WriteQuotaAvailable > 0)
{
- CopyLength = RtlRosMin(Length, Fcb->WriteQuotaAvailable);
- if (Fcb->WritePtr + CopyLength <= Fcb->Data +
Fcb->MaxDataLength)
+ CopyLength = RtlRosMin(Length,
ReaderFcb->WriteQuotaAvailable);
+ if (ReaderFcb->WritePtr + CopyLength <= ReaderFcb->Data +
ReaderFcb->MaxDataLength)
{
- memcpy(Fcb->WritePtr, Buffer, CopyLength);
- Fcb->WritePtr += CopyLength;
- if (Fcb->WritePtr == Fcb->Data + Fcb->MaxDataLength)
+ memcpy(ReaderFcb->WritePtr, Buffer, CopyLength);
+ ReaderFcb->WritePtr += CopyLength;
+ if (ReaderFcb->WritePtr == ReaderFcb->Data +
ReaderFcb->MaxDataLength)
{
- Fcb->WritePtr = Fcb->Data;
+ ReaderFcb->WritePtr = ReaderFcb->Data;
}
}
else
{
- TempLength = Fcb->Data + Fcb->MaxDataLength -
Fcb->WritePtr;
- memcpy(Fcb->WritePtr, Buffer, TempLength);
- memcpy(Fcb->Data, Buffer + TempLength, CopyLength -
TempLength);
- Fcb->WritePtr = Fcb->Data + CopyLength - TempLength;
+ TempLength = ReaderFcb->Data +
ReaderFcb->MaxDataLength - ReaderFcb->WritePtr;
+ memcpy(ReaderFcb->WritePtr, Buffer, TempLength);
+ memcpy(ReaderFcb->Data, Buffer + TempLength,
CopyLength - TempLength);
+ ReaderFcb->WritePtr = ReaderFcb->Data + CopyLength -
TempLength;
}
Buffer += CopyLength;
Length -= CopyLength;
Information += CopyLength;
- Fcb->ReadDataAvailable += CopyLength;
- Fcb->WriteQuotaAvailable -= CopyLength;
+ ReaderFcb->ReadDataAvailable += CopyLength;
+ ReaderFcb->WriteQuotaAvailable -= CopyLength;
}
if (Length == 0)
{
- KeSetEvent(&Fcb->OtherSide->Event, IO_NO_INCREMENT,
FALSE);
+ KeSetEvent(&ReaderFcb->Event, IO_NO_INCREMENT, FALSE);
break;
}
}
@@ -405,23 +357,23 @@
DPRINT("Message mode\n");
if (Length > 0)
{
- CopyLength = RtlRosMin(Length, Fcb->WriteQuotaAvailable);
- memcpy(Fcb->Data, Buffer, CopyLength);
+ CopyLength = RtlRosMin(Length,
ReaderFcb->WriteQuotaAvailable);
+ memcpy(ReaderFcb->Data, Buffer, CopyLength);
Information = CopyLength;
- Fcb->ReadDataAvailable = CopyLength;
- Fcb->WriteQuotaAvailable = 0;
+ ReaderFcb->ReadDataAvailable = CopyLength;
+ ReaderFcb->WriteQuotaAvailable = 0;
}
if (Information > 0)
{
- KeSetEvent(&Fcb->OtherSide->Event, IO_NO_INCREMENT,
FALSE);
+ KeSetEvent(&ReaderFcb->Event, IO_NO_INCREMENT, FALSE);
break;
}
}
}
- KeReleaseSpinLock(&Fcb->DataListLock, OldIrql);
+ KeReleaseSpinLock(&ReaderFcb->DataListLock, OldIrql);
done:
Irp->IoStatus.Status = Status;
_____
Modified: trunk/reactos/drivers/fs/np/volume.c
--- trunk/reactos/drivers/fs/np/volume.c 2005-02-26 23:22:48 UTC
(rev 13762)
+++ trunk/reactos/drivers/fs/np/volume.c 2005-02-27 12:43:37 UTC
(rev 13763)
@@ -2,9 +2,9 @@
*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
- * FILE: services/fs/npfs/volume.c
+ * FILE: drivers/fs/npfs/volume.c
* PURPOSE: Named pipe filesystem
- * PROGRAMMER: Eric Kohl <ekohl@rz-online.de>
+ * PROGRAMMER: Eric Kohl
*/
/* INCLUDES
*****************************************************************/
@@ -23,20 +23,20 @@
NpfsQueryFsDeviceInformation(PFILE_FS_DEVICE_INFORMATION FsDeviceInfo,
PULONG BufferLength)
{
- DPRINT("NpfsQueryFsDeviceInformation()\n");
- DPRINT("FsDeviceInfo = %p\n", FsDeviceInfo);
-
- if (*BufferLength < sizeof(FILE_FS_DEVICE_INFORMATION))
- return(STATUS_BUFFER_OVERFLOW);
-
- FsDeviceInfo->DeviceType = FILE_DEVICE_NAMED_PIPE;
- FsDeviceInfo->Characteristics = 0;
-
- *BufferLength -= sizeof(FILE_FS_DEVICE_INFORMATION);
-
- DPRINT("NpfsQueryFsDeviceInformation() finished.\n");
-
- return(STATUS_SUCCESS);
+ DPRINT("NpfsQueryFsDeviceInformation()\n");
+ DPRINT("FsDeviceInfo = %p\n", FsDeviceInfo);
+
+ if (*BufferLength < sizeof(FILE_FS_DEVICE_INFORMATION))
+ return STATUS_BUFFER_OVERFLOW;
+
+ FsDeviceInfo->DeviceType = FILE_DEVICE_NAMED_PIPE;
+ FsDeviceInfo->Characteristics = 0;
+
+ *BufferLength -= sizeof(FILE_FS_DEVICE_INFORMATION);
+
+ DPRINT("NpfsQueryFsDeviceInformation() finished.\n");
+
+ return STATUS_SUCCESS;
}
@@ -44,22 +44,22 @@
NpfsQueryFsAttributeInformation(PFILE_FS_ATTRIBUTE_INFORMATION
FsAttributeInfo,
PULONG BufferLength)
{
- DPRINT("NpfsQueryFsAttributeInformation() called.\n");
- DPRINT("FsAttributeInfo = %p\n", FsAttributeInfo);
-
- if (*BufferLength < sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8)
- return(STATUS_BUFFER_OVERFLOW);
-
- FsAttributeInfo->FileSystemAttributes = FILE_CASE_PRESERVED_NAMES;
- FsAttributeInfo->MaximumComponentNameLength = 255;
- FsAttributeInfo->FileSystemNameLength = 8;
- wcscpy(FsAttributeInfo->FileSystemName,
- L"NPFS");
-
- DPRINT("NpfsQueryFsAttributeInformation() finished.\n");
- *BufferLength -= (sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8);
-
- return(STATUS_SUCCESS);
+ DPRINT("NpfsQueryFsAttributeInformation() called.\n");
+ DPRINT("FsAttributeInfo = %p\n", FsAttributeInfo);
+
+ if (*BufferLength < sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8)
+ return STATUS_BUFFER_OVERFLOW;
+
+ FsAttributeInfo->FileSystemAttributes = FILE_CASE_PRESERVED_NAMES;
+ FsAttributeInfo->MaximumComponentNameLength = 255;
+ FsAttributeInfo->FileSystemNameLength = 8;
+ wcscpy(FsAttributeInfo->FileSystemName,
+ L"NPFS");
+
+ DPRINT("NpfsQueryFsAttributeInformation() finished.\n");
+ *BufferLength -= (sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8);
+
+ return STATUS_SUCCESS;
}
@@ -67,54 +67,53 @@
NpfsQueryVolumeInformation(PDEVICE_OBJECT DeviceObject,
PIRP Irp)
{
- PIO_STACK_LOCATION Stack;
- FS_INFORMATION_CLASS FsInformationClass;
- NTSTATUS Status = STATUS_SUCCESS;
- PVOID SystemBuffer;
- ULONG BufferLength;
-
- /* PRECONDITION */
- assert(DeviceObject != NULL);
- assert(Irp != NULL);
-
- DPRINT("NpfsQueryVolumeInformation(DeviceObject %x, Irp %x)\n",
- DeviceObject,
- Irp);
-
- Stack = IoGetCurrentIrpStackLocation (Irp);
- FsInformationClass =
Stack->Parameters.QueryVolume.FsInformationClass;
- BufferLength = Stack->Parameters.QueryVolume.Length;
- SystemBuffer = Irp->AssociatedIrp.SystemBuffer;
-
- DPRINT("FsInformationClass %d\n", FsInformationClass);
- DPRINT("SystemBuffer %x\n", SystemBuffer);
-
- switch (FsInformationClass)
- {
- case FileFsDeviceInformation:
- Status = NpfsQueryFsDeviceInformation(SystemBuffer,
- &BufferLength);
- break;
-
- case FileFsAttributeInformation:
- Status = NpfsQueryFsAttributeInformation(SystemBuffer,
- &BufferLength);
- break;
-
- default:
- Status = STATUS_NOT_SUPPORTED;
- }
-
- Irp->IoStatus.Status = Status;
- if (NT_SUCCESS(Status))
- Irp->IoStatus.Information =
- Stack->Parameters.QueryVolume.Length - BufferLength;
- else
- Irp->IoStatus.Information = 0;
- IoCompleteRequest(Irp,
- IO_NO_INCREMENT);
-
- return(Status);
+ PIO_STACK_LOCATION Stack;
+ FS_INFORMATION_CLASS FsInformationClass;
+ NTSTATUS Status = STATUS_SUCCESS;
+ PVOID SystemBuffer;
+ ULONG BufferLength;
+
+ /* PRECONDITION */
+ ASSERT(DeviceObject != NULL);
+ ASSERT(Irp != NULL);
+
+ DPRINT("NpfsQueryVolumeInformation(DeviceObject %x, Irp %x)\n",
+ DeviceObject,
+ Irp);
+
+ Stack = IoGetCurrentIrpStackLocation(Irp);
+ FsInformationClass =
Stack->Parameters.QueryVolume.FsInformationClass;
+ BufferLength = Stack->Parameters.QueryVolume.Length;
+ SystemBuffer = Irp->AssociatedIrp.SystemBuffer;
+
+ DPRINT("FsInformationClass %d\n", FsInformationClass);
+ DPRINT("SystemBuffer %x\n", SystemBuffer);
+
+ switch (FsInformationClass)
+ {
+ case FileFsDeviceInformation:
+ Status = NpfsQueryFsDeviceInformation(SystemBuffer,
+ &BufferLength);
+ break;
+
+ case FileFsAttributeInformation:
+ Status = NpfsQueryFsAttributeInformation(SystemBuffer,
+ &BufferLength);
+ break;
+
+ default:
+ Status = STATUS_NOT_SUPPORTED;
+ }
+
+ Irp->IoStatus.Status = Status;
+ if (NT_SUCCESS(Status))
+ Irp->IoStatus.Information = Stack->Parameters.QueryVolume.Length -
BufferLength;
+ else
+ Irp->IoStatus.Information = 0;
+ IoCompleteRequest(Irp,
+ IO_NO_INCREMENT);
+
+ return Status;
}
/* EOF */
[Attachment #3 (text/html)]
<html>
<head>
<style>
<!--
body { background-color:#ffffff }
.file { border:1px solid #eeeeee; margin-top:1em; margin-bottom:1em }
.pathname { font-family:monospace; float:right }
.fileheader { margin-bottom:.5em }
.diff { margin:0 }
.tasklist { padding:4px; border:1px dashed #000000; margin-top:1em }
.tasklist ul { margin-top:0; margin-bottom:0 }
tr.alt { background-color:#eeeeee }
#added { background-color:#ddffdd }
#addedchars { background-color:#99ff99; font-weight:bolder }
tr.alt #added { background-color:#ccf7cc }
#removed { background-color:#ffdddd }
#removedchars { background-color:#ff9999; font-weight:bolder }
tr.alt #removed { background-color:#f7cccc }
#info { color:#888888 }
#context { background-color:#eeeeee }
td {padding-left:.3em; padding-right:.3em }
tr.head { border-bottom-width:1px; border-bottom-style:solid }
tr.head td { padding:0; padding-top:.2em }
.task { background-color:#ffff00 }
.comment { padding:4px; border:1px dashed #000000; background-color:#ffffdd }
.error { color:red }
hr { border-width:0px; height:2px; background:black }
-->
</style>
</head>
<body>
<pre class="comment">- Data is now written to the readers data buffer and the reader \
reads from his own data buffer. This fixes Filip's wrokaround to enable the reader to \
read data although the writers side was closed.
- Minor cleanup.</pre><pre class="diff" id="context">Modified: \
trunk/reactos/drivers/fs/np/create.c
Modified: trunk/reactos/drivers/fs/np/finfo.c
Modified: trunk/reactos/drivers/fs/np/fsctrl.c
Modified: trunk/reactos/drivers/fs/np/npfs.c
Modified: trunk/reactos/drivers/fs/np/npfs.h
Modified: trunk/reactos/drivers/fs/np/rw.c
Modified: trunk/reactos/drivers/fs/np/volume.c
</pre><hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/create.c</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/create.c 2005-02-26 23:22:48 UTC (rev \
13762)
+++ trunk/reactos/drivers/fs/np/create.c 2005-02-27 12:43:37 UTC (rev 13763)
@@ -2,7 +2,7 @@
</small></pre><pre class="diff" id="context"> *
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
</pre><pre class="diff" id="removed">- * FILE: <span \
id="removedchars">service</span>s/fs/np/create.c </pre><pre class="diff" id="added">+ \
* FILE: <span id="addedchars">driver</span>s/fs/np/create.c \
</pre><pre class="diff" id="context"> * PURPOSE: Named pipe \
filesystem * PROGRAMMER: David Welch <welch@cwcom.net>
*/
@@ -164,9 +164,9 @@
</pre><pre class="diff" id="context"> ClientFcb->PipeState = SpecialAccess \
? 0 : FILE_PIPE_DISCONNECTED_STATE;
/* Initialize data list. */
</pre><pre class="diff" id="removed">- if (Pipe-><span \
id="removedchars">In</span>boundQuota) </pre><pre class="diff" id="added">+ if \
(Pipe-><span id="addedchars">Out</span>boundQuota) </pre><pre class="diff" \
id="context"> { </pre><pre class="diff" id="removed">- \
ClientFcb->Data = ExAllocatePool(NonPagedPool, Pipe-><span \
id="removedchars">In</span>boundQuota); </pre><pre class="diff" id="added">+ \
ClientFcb->Data = ExAllocatePool(NonPagedPool, Pipe-><span \
id="addedchars">Out</span>boundQuota); </pre><pre class="diff" id="context"> \
if (ClientFcb->Data == NULL) {
DPRINT("No memory!\n");
@@ -185,8 +185,8 @@
</pre><pre class="diff" id="context"> ClientFcb->ReadPtr = \
ClientFcb->Data; ClientFcb->WritePtr = ClientFcb->Data;
ClientFcb->ReadDataAvailable = 0;
</pre><pre class="diff" id="removed">- ClientFcb->WriteQuotaAvailable = \
Pipe->InboundQuota;
- ClientFcb-><span id="removedchars">MaxDataLength = \
Pipe->In</span>boundQuota; </pre><pre class="diff" id="added">+ \
ClientFcb-><span id="addedchars">WriteQuotaAvailable = \
Pipe->Out</span>boundQuota; + ClientFcb->MaxDataLength = \
Pipe->OutboundQuota; </pre><pre class="diff" id="context"> \
KeInitializeSpinLock(&ClientFcb->DataListLock); \
KeInitializeEvent(&ClientFcb->ConnectEvent, SynchronizationEvent, FALSE); \
KeInitializeEvent(&ClientFcb->Event, SynchronizationEvent, FALSE); @@ \
-381,9 +381,9 @@ </pre><pre class="diff" id="context"> \
KeUnlockMutex(&DeviceExt->PipeListLock); }
</pre><pre class="diff" id="removed">- if (Pipe-><span \
id="removedchars">Out</span>boundQuota) </pre><pre class="diff" id="added">+ \
if (Pipe-><span id="addedchars">In</span>boundQuota) </pre><pre class="diff" \
id="context"> { </pre><pre class="diff" id="removed">- \
Fcb->Data = ExAllocatePool(NonPagedPool, Pipe-><span \
id="removedchars">Out</span>boundQuota); </pre><pre class="diff" id="added">+ \
Fcb->Data = ExAllocatePool(NonPagedPool, Pipe-><span \
id="addedchars">In</span>boundQuota); </pre><pre class="diff" id="context"> \
if (Fcb->Data == NULL) {
ExFreePool(Fcb);
@@ -407,8 +407,8 @@
</pre><pre class="diff" id="context"> Fcb->ReadPtr = Fcb->Data;
Fcb->WritePtr = Fcb->Data;
Fcb->ReadDataAvailable = 0;
</pre><pre class="diff" id="removed">- Fcb->WriteQuotaAvailable = \
Pipe->OutboundQuota;
- Fcb-><span id="removedchars">MaxDataLength = \
Pipe->Out</span>boundQuota; </pre><pre class="diff" id="added">+ \
Fcb-><span id="addedchars">WriteQuotaAvailable = Pipe->In</span>boundQuota; + \
Fcb->MaxDataLength = Pipe->InboundQuota; </pre><pre class="diff" \
id="context"> KeInitializeSpinLock(&Fcb->DataListLock);
Pipe->CurrentInstances++;
@@ -442,9 +442,8 @@
</pre><pre class="diff" id="context">
NTSTATUS STDCALL
</pre><pre class="diff" id="removed">-NpfsClose(
- PDEVICE_OBJECT DeviceObject,
- PIRP Irp)
</pre><pre class="diff" id="added">+NpfsClose(PDEVICE_OBJECT DeviceObject,
+ PIRP Irp)
</pre><pre class="diff" id="context"> {
PNPFS_DEVICE_EXTENSION DeviceExt;
PIO_STACK_LOCATION IoStack;
@@ -493,10 +492,8 @@
</pre><pre class="diff" id="context"> {
if (Fcb->OtherSide)
{
</pre><pre class="diff" id="removed">-#ifndef FIN_WORKAROUND_READCLOSE
</pre><pre class="diff" id="context"> \
Fcb->OtherSide->PipeState = FILE_PIPE_CLOSING_STATE; \
Fcb->OtherSide->OtherSide = NULL; </pre><pre class="diff" \
id="removed">-#endif </pre><pre class="diff" id="context"> \
/* * Signaling the write event. If \
is possible that an other * thread waits for an \
empty buffer. @@ -504,40 +501,16 @@
</pre><pre class="diff" id="context"> \
KeSetEvent(&Fcb->OtherSide->Event, IO_NO_INCREMENT, FALSE); \
}
</pre><pre class="diff" id="removed">-#ifndef FIN_WORKAROUND_READCLOSE
</pre><pre class="diff" id="context"> Fcb->PipeState = 0;
</pre><pre class="diff" id="removed">-#endif
</pre><pre class="diff" id="context"> }
FileObject->FsContext = NULL;
</pre><pre class="diff" id="removed">-#ifndef FIN_WORKAROUND_READCLOSE
</pre><pre class="diff" id="context"> \
RemoveEntryList(&Fcb->FcbListEntry); if (Fcb->Data)
ExFreePool(Fcb->Data);
ExFreePool(Fcb);
</pre><pre class="diff" id="removed">-#else
- Fcb->PipeState = FILE_PIPE_CLOSING_STATE;
- if (Fcb->OtherSide == NULL ||
- Fcb->OtherSide->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- if (Server && Fcb->OtherSide != NULL &&
- Fcb->OtherSide->PipeState == \
FILE_PIPE_CLOSING_STATE)
- {
- \
RemoveEntryList(&Fcb->OtherSide->FcbListEntry);
- if (Fcb->OtherSide->Data)
- ExFreePool(Fcb->OtherSide->Data);
- ExFreePool(Fcb->OtherSide);
- }
</pre><pre class="diff" id="context">
</pre><pre class="diff" id="removed">- \
RemoveEntryList(&Fcb->FcbListEntry);
- if (Fcb->Data)
- ExFreePool(Fcb->Data);
-
- ExFreePool(Fcb);
- }
-#endif
-
</pre><pre class="diff" id="context"> \
KeUnlockMutex(&Pipe->FcbListLock);
if (IsListEmpty(&Pipe->ServerFcbListHead) &&
</pre></div>
<hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/finfo.c</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/finfo.c 2005-02-26 23:22:48 \
UTC (rev 13762)
+++ trunk/reactos/drivers/fs/np/finfo.c 2005-02-27 12:43:37 UTC (rev 13763)
@@ -2,9 +2,9 @@
</small></pre><pre class="diff" id="context"> *
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
</pre><pre class="diff" id="removed">- * FILE: <span \
id="removedchars">service</span>s/fs/np/finfo.c </pre><pre class="diff" id="added">+ \
* FILE: <span id="addedchars">driver</span>s/fs/np/finfo.c \
</pre><pre class="diff" id="context"> * PURPOSE: Named pipe \
filesystem </pre><pre class="diff" id="removed">- * PROGRAMMER: Eric Kohl<span \
id="removedchars"> <ekohl@rz-online.de></span> </pre><pre class="diff" \
id="added">+ * PROGRAMMER: Eric Kohl </pre><pre class="diff" id="context"> */
/* INCLUDES ******************************************************************/
@@ -36,7 +36,7 @@
</pre><pre class="diff" id="context"> // Info->CompletionMode =
*BufferLength -= sizeof(FILE_PIPE_INFORMATION);
</pre><pre class="diff" id="removed">- return<span \
id="removedchars">(STATUS_SUCCESS)</span>; </pre><pre class="diff" id="added">+ \
return<span id="addedchars"> STATUS_SUCCESS</span>; </pre><pre class="diff" \
id="context"> }
@@ -76,7 +76,7 @@
</pre><pre class="diff" id="context"> }
*BufferLength -= sizeof(FILE_PIPE_LOCAL_INFORMATION);
</pre><pre class="diff" id="removed">- return<span \
id="removedchars">(STATUS_SUCCESS)</span>; </pre><pre class="diff" id="added">+ \
return<span id="addedchars"> STATUS_SUCCESS</span>; </pre><pre class="diff" \
id="context"> }
@@ -93,24 +93,24 @@
</pre><pre class="diff" id="context"> PVOID SystemBuffer;
ULONG BufferLength;
NTSTATUS Status;
</pre><pre class="diff" id="removed">-
</pre><pre class="diff" id="added">+
</pre><pre class="diff" id="context"> \
DPRINT("NpfsQueryInformation(DeviceObject %p Irp %p)\n", DeviceObject, \
Irp); </pre><pre class="diff" id="removed">-
</pre><pre class="diff" id="added">+
</pre><pre class="diff" id="context"> IoStack = IoGetCurrentIrpStackLocation \
(Irp); FileInformationClass = \
IoStack->Parameters.QueryFile.FileInformationClass; DeviceExtension = \
DeviceObject->DeviceExtension; FileObject = IoStack->FileObject;
Fcb = (PNPFS_FCB)FileObject->FsContext;
Pipe = Fcb->Pipe;
</pre><pre class="diff" id="removed">-
</pre><pre class="diff" id="added">+
</pre><pre class="diff" id="context"> SystemBuffer = \
Irp->AssociatedIrp.SystemBuffer; BufferLength = \
IoStack->Parameters.QueryFile.Length; </pre><pre class="diff" id="removed">- \
</pre><pre class="diff" id="added">+
</pre><pre class="diff" id="context"> DPRINT("Pipe name: %wZ\n", \
&Pipe->PipeName); DPRINT("FileInformationClass %d\n", \
FileInformationClass); DPRINT("SystemBuffer %p\n", SystemBuffer);
DPRINT("BufferLength %lu\n", BufferLength);
</pre><pre class="diff" id="removed">-
</pre><pre class="diff" id="added">+
</pre><pre class="diff" id="context"> switch (FileInformationClass)
{
case FilePipeInformation:
@@ -134,7 +134,7 @@
</pre><pre class="diff" id="context"> default:
Status = STATUS_NOT_SUPPORTED;
}
</pre><pre class="diff" id="removed">-
</pre><pre class="diff" id="added">+
</pre><pre class="diff" id="context"> Irp->IoStatus.Status = Status;
if (NT_SUCCESS(Status))
Irp->IoStatus.Information =
@@ -142,8 +142,8 @@
</pre><pre class="diff" id="context"> else
Irp->IoStatus.Information = 0;
IoCompleteRequest (Irp, IO_NO_INCREMENT);
</pre><pre class="diff" id="removed">-
- return(Status);
</pre><pre class="diff" id="added">+
+ return Status;
</pre><pre class="diff" id="context"> }
@@ -196,7 +196,7 @@
</pre><pre class="diff" id="context"> IoCompleteRequest(Irp,
IO_NO_INCREMENT);
</pre><pre class="diff" id="removed">- return<span \
id="removedchars">(Status)</span>; </pre><pre class="diff" id="added">+ \
return<span id="addedchars"> Status</span>; </pre><pre class="diff" \
id="context"> }
/* EOF */
</pre></div>
<hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/fsctrl.c</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/fsctrl.c 2005-02-26 23:22:48 UTC (rev \
13762)
+++ trunk/reactos/drivers/fs/np/fsctrl.c 2005-02-27 12:43:37 UTC (rev 13763)
@@ -2,10 +2,10 @@
</small></pre><pre class="diff" id="context"> *
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
</pre><pre class="diff" id="removed">- * FILE: <span \
id="removedchars">service</span>s/fs/np/fsctrl.c </pre><pre class="diff" id="added">+ \
* FILE: <span id="addedchars">driver</span>s/fs/np/fsctrl.c \
</pre><pre class="diff" id="context"> * PURPOSE: Named pipe \
filesystem * PROGRAMMER: David Welch <welch@cwcom.net>
</pre><pre class="diff" id="removed">- * \
Eric Kohl<span id="removedchars"> <ekohl@rz-online.de></span> </pre><pre \
class="diff" id="added">+ * Eric Kohl \
</pre><pre class="diff" id="context"> */
/* INCLUDES ******************************************************************/
</pre></div>
<hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/npfs.c</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/npfs.c 2005-02-26 23:22:48 \
UTC (rev 13762)
+++ trunk/reactos/drivers/fs/np/npfs.c 2005-02-27 12:43:37 UTC (rev 13763)
@@ -2,7 +2,7 @@
</small></pre><pre class="diff" id="context"> *
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
</pre><pre class="diff" id="removed">- * FILE: <span \
id="removedchars">service</span>s/fs/np/mount.c </pre><pre class="diff" id="added">+ \
* FILE: <span id="addedchars">driver</span>s/fs/np/mount.c \
</pre><pre class="diff" id="context"> * PURPOSE: Named pipe \
filesystem * PROGRAMMER: David Welch <welch@cwcom.net>
*/
@@ -64,7 +64,7 @@
</pre><pre class="diff" id="context"> if (!NT_SUCCESS(Status))
{
DPRINT("Failed to create named pipe device! (Status %x)\n", Status);
</pre><pre class="diff" id="removed">- return<span id="removedchars">(Status)</span>;
</pre><pre class="diff" id="added">+ return<span id="addedchars"> Status</span>;
</pre><pre class="diff" id="context"> }
/* initialize the device object */
@@ -81,7 +81,7 @@
</pre><pre class="diff" id="context"> DeviceExtension->DefaultQuota = \
8 * PAGE_SIZE; DeviceExtension->MaxQuota = 64 * PAGE_SIZE;
</pre><pre class="diff" id="removed">- return<span \
id="removedchars">(STATUS_SUCCESS)</span>; </pre><pre class="diff" id="added">+ \
return<span id="addedchars"> STATUS_SUCCESS</span>; </pre><pre class="diff" \
id="context"> }
/* EOF */
</pre></div>
<hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/npfs.h</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/npfs.h 2005-02-26 23:22:48 \
UTC (rev 13762)
+++ trunk/reactos/drivers/fs/np/npfs.h 2005-02-27 12:43:37 UTC (rev 13763)
@@ -1,14 +1,8 @@
</small></pre><pre class="diff" id="context"> /* $Id$ */
</pre><pre class="diff" id="removed">-#ifndef __SERVICES_FS_NP_NPFS_H
-#<span id="removedchars">define __SERVICE</span>S_FS_NP_NPFS_H
</pre><pre class="diff" id="added">+#<span id="addedchars">ifndef \
__DRIVER</span>S_FS_NP_NPFS_H +#define __DRIVERS_FS_NP_NPFS_H
</pre><pre class="diff" id="context">
</pre><pre class="diff" id="removed">-/*
- * Hacky support for delayed closing of pipes. We need this to support
- * reading from pipe the was closed on one end.
- */
-#define FIN_WORKAROUND_READCLOSE
-
</pre><pre class="diff" id="context"> typedef struct _NPFS_DEVICE_EXTENSION
{
LIST_ENTRY PipeListHead;
@@ -70,9 +64,7 @@
</pre><pre class="diff" id="context">
#define KeUnlockMutex(x) KeReleaseMutex(x, FALSE);
</pre><pre class="diff" id="removed">-#define CP DPRINT("\n");
</pre><pre class="diff" id="context">
</pre><pre class="diff" id="removed">-
</pre><pre class="diff" id="context"> NTSTATUS STDCALL NpfsCreate(PDEVICE_OBJECT \
DeviceObject, PIRP Irp); NTSTATUS STDCALL NpfsCreateNamedPipe(PDEVICE_OBJECT \
DeviceObject, PIRP Irp); NTSTATUS STDCALL NpfsClose(PDEVICE_OBJECT DeviceObject, \
PIRP Irp); @@ -89,4 +81,4 @@
</pre><pre class="diff" id="context">
NTSTATUS STDCALL NpfsQueryVolumeInformation (PDEVICE_OBJECT DeviceObject, PIRP Irp);
</pre><pre class="diff" id="removed">-#endif /* __<span \
id="removedchars">SERVICE</span>S_FS_NP_NPFS_H */ </pre><pre class="diff" \
id="added">+#endif /* __<span id="addedchars">DRIVER</span>S_FS_NP_NPFS_H */ \
</pre></div> <hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/rw.c</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/rw.c 2005-02-26 23:22:48 \
UTC (rev 13762)
+++ trunk/reactos/drivers/fs/np/rw.c 2005-02-27 12:43:37 UTC (rev 13763)
@@ -2,7 +2,7 @@
</small></pre><pre class="diff" id="context"> *
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
</pre><pre class="diff" id="removed">- * FILE: <span \
id="removedchars">service</span>s/fs/np/rw.c </pre><pre class="diff" id="added">+ * \
FILE: <span id="addedchars">driver</span>s/fs/np/rw.c </pre><pre \
class="diff" id="context"> * PURPOSE: Named pipe filesystem \
* PROGRAMMER: David Welch <welch@cwcom.net> */
@@ -16,8 +16,6 @@
</pre><pre class="diff" id="context"> #define NDEBUG
#include <debug.h>
</pre><pre class="diff" id="removed">-#define FIN_WORKAROUND_READCLOSE
-
</pre><pre class="diff" id="context"> /* FUNCTIONS \
*****************************************************************/
#ifndef NDEBUG
@@ -60,7 +58,7 @@
</pre><pre class="diff" id="context"> KIRQL OldIrql;
ULONG Information;
PNPFS_FCB Fcb;
</pre><pre class="diff" id="removed">- PNPFS_FCB <span \
id="removedchars">Read</span>Fcb; </pre><pre class="diff" id="added">+ \
PNPFS_FCB <span id="addedchars">Writer</span>Fcb; </pre><pre class="diff" \
id="context"> PNPFS_PIPE Pipe; ULONG Length;
PVOID Buffer;
@@ -74,22 +72,8 @@
</pre><pre class="diff" id="context"> FileObject = IoStack->FileObject;
Fcb = FileObject->FsContext;
Pipe = Fcb->Pipe;
</pre><pre class="diff" id="removed">- <span id="removedchars">Read</span>Fcb = \
Fcb->OtherSide; </pre><pre class="diff" id="added">+ <span \
id="addedchars">Writer</span>Fcb = Fcb->OtherSide; </pre><pre class="diff" \
id="context"> </pre><pre class="diff" id="removed">- if (ReadFcb == NULL)
- {
- DPRINT("Pipe is NOT connected!\n");
- if (Fcb->PipeState == FILE_PIPE_LISTENING_STATE)
- Status = STATUS_PIPE_LISTENING;
- else if (Fcb->PipeState == FILE_PIPE_DISCONNECTED_STATE)
- Status = STATUS_PIPE_DISCONNECTED;
- else
- Status = STATUS_PIPE_BROKEN;
- Information = 0;
- DPRINT("%x\n", Status);
- goto done;
- }
-
</pre><pre class="diff" id="context"> if (Irp->MdlAddress == NULL)
{
DPRINT("Irp->MdlAddress == NULL\n");
@@ -98,7 +82,7 @@
</pre><pre class="diff" id="context"> goto done;
}
</pre><pre class="diff" id="removed">- if (<span \
id="removedchars">Read</span>Fcb->Data == NULL) </pre><pre class="diff" \
id="added">+ if (Fcb->Data == NULL) </pre><pre class="diff" id="context"> \
{ DPRINT("Pipe is NOT readable!\n");
Status = STATUS_UNSUCCESSFUL;
@@ -106,31 +90,20 @@
</pre><pre class="diff" id="context"> goto done;
}
</pre><pre class="diff" id="removed">-#ifdef FIN_WORKAROUND_READCLOSE
- if (ReadFcb->ReadDataAvailable == 0 &&
- ReadFcb->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- DPRINT("Other end of pipe is closed!\n");
- Status = STATUS_PIPE_BROKEN;
- Information = 0;
- goto done;
- }
-#endif
-
</pre><pre class="diff" id="context"> Status = STATUS_SUCCESS;
Length = IoStack->Parameters.Read.Length;
Information = 0;
Buffer = MmGetSystemAddressForMdl(Irp->MdlAddress);
</pre><pre class="diff" id="removed">- KeAcquireSpinLock(&<span \
id="removedchars">Read</span>Fcb->DataListLock, &OldIrql); </pre><pre \
class="diff" id="added">+ KeAcquireSpinLock(&Fcb->DataListLock, \
&OldIrql); </pre><pre class="diff" id="context"> while (1)
{
/* FIXME: check if in blocking mode */
</pre><pre class="diff" id="removed">- if (<span \
id="removedchars">Read</span>Fcb->ReadDataAvailable == 0) </pre><pre class="diff" \
id="added">+ if (Fcb->ReadDataAvailable == 0) </pre><pre \
class="diff" id="context"> { KeResetEvent(&Fcb->Event);
</pre><pre class="diff" id="removed">- KeSetEvent(&ReadFcb->Event, \
IO_NO_INCREMENT, FALSE);
- Ke<span id="removedchars">ReleaseSpinLock(&ReadFcb->DataListLock, \
OldIrql</span>); </pre><pre class="diff" id="added">+ Ke<span \
id="addedchars">SetEvent(&WriterFcb->Event, IO_NO_INCREMENT, FALSE</span>); + \
KeReleaseSpinLock(&Fcb->DataListLock, OldIrql); </pre><pre class="diff" \
id="context"> if (Information > 0) {
Status = STATUS_SUCCESS;
@@ -153,56 +126,44 @@
</pre><pre class="diff" id="context"> NULL);
DPRINT("Finished waiting (%S)! Status: %x\n", \
Pipe->PipeName.Buffer, Status);
</pre><pre class="diff" id="removed">-#ifndef FIN_WORKAROUND_READCLOSE
- /*
- * It's possible that the event was signaled because the
- * other side of pipe was closed.
- */
- if (Fcb->PipeState != FILE_PIPE_CONNECTED_STATE)
- {
- DPRINT("PipeState: %x\n", Fcb->PipeState);
- Status = STATUS_PIPE_BROKEN;
- goto done;
- }
-#endif
- KeAcquireSpinLock(&<span \
id="removedchars">Read</span>Fcb->DataListLock, &OldIrql); </pre><pre \
class="diff" id="added">+ KeAcquireSpinLock(&Fcb->DataListLock, \
&OldIrql); </pre><pre class="diff" id="context"> }
if (Pipe->ReadMode == FILE_PIPE_BYTE_STREAM_MODE)
{
DPRINT("Byte stream mode\n");
/* Byte stream mode */
</pre><pre class="diff" id="removed">- while (Length > 0 && <span \
id="removedchars">Read</span>Fcb->ReadDataAvailable > 0) </pre><pre \
class="diff" id="added">+ while (Length > 0 && \
Fcb->ReadDataAvailable > 0) </pre><pre class="diff" id="context"> \
{ </pre><pre class="diff" id="removed">- CopyLength = \
RtlRosMin(ReadFcb->ReadDataAvailable, Length);
- <span id="removedchars">if (ReadFcb->ReadPtr + CopyLength \
<= ReadFcb->Data + ReadFcb->MaxDataLength)</span> </pre><pre class="diff" \
id="added">+ <span id="addedchars">CopyLength = \
RtlRosMin(Fcb->ReadDataAvailable, Length);</span> + if \
(Fcb->ReadPtr + CopyLength <= Fcb->Data + Fcb->MaxDataLength) </pre><pre \
class="diff" id="context"> { </pre><pre class="diff" id="removed">- \
memcpy(Buffer, ReadFcb->ReadPtr, CopyLength);
- ReadFcb->ReadPtr += CopyLength;
- <span id="removedchars">if (ReadFcb->ReadPtr == ReadFcb->Data + \
ReadFcb->MaxDataLength)</span> </pre><pre class="diff" id="added">+ <span \
id="addedchars">memcpy(Buffer, Fcb->ReadPtr, CopyLength);</span> + \
Fcb->ReadPtr += CopyLength; + if (Fcb->ReadPtr == Fcb->Data + \
Fcb->MaxDataLength) </pre><pre class="diff" id="context"> {
</pre><pre class="diff" id="removed">- <span \
id="removedchars">ReadFcb->ReadPtr = Read</span>Fcb->Data; </pre><pre \
class="diff" id="added">+ <span id="addedchars">Fcb->ReadPtr \
= </span>Fcb->Data; </pre><pre class="diff" id="context"> }
}
else
{
</pre><pre class="diff" id="removed">- TempLength = ReadFcb->Data + \
ReadFcb->MaxDataLength - ReadFcb->ReadPtr;
- memcpy(Buffer, ReadFcb->ReadPtr, TempLength);
- memcpy(Buffer + TempLength, ReadFcb->Data, CopyLength - TempLength);
- <span id="removedchars">ReadFcb->ReadPtr = ReadFcb->Data + CopyLength \
- TempLength</span>; </pre><pre class="diff" id="added">+ <span \
id="addedchars">TempLength = Fcb->Data + Fcb->MaxDataLength - \
Fcb->ReadPtr</span>; + memcpy(Buffer, Fcb->ReadPtr, TempLength);
+ memcpy(Buffer + TempLength, Fcb->Data, CopyLength - TempLength);
+ Fcb->ReadPtr = Fcb->Data + CopyLength - TempLength;
</pre><pre class="diff" id="context"> }
Buffer += CopyLength;
Length -= CopyLength;
Information += CopyLength;
</pre><pre class="diff" id="removed">- \
ReadFcb->ReadDataAvailable -= CopyLength;
- <span id="removedchars">ReadFcb->WriteQuotaAvailable \
+</span>= CopyLength; </pre><pre class="diff" id="added">+ <span \
id="addedchars">Fcb->ReadDataAvailable -</span>= CopyLength; + \
Fcb->WriteQuotaAvailable += CopyLength; </pre><pre class="diff" \
id="context"> }
if (Length == 0)
{
</pre><pre class="diff" id="removed">- KeSetEvent(&<span \
id="removedchars">Read</span>Fcb->Event, IO_NO_INCREMENT, FALSE); </pre><pre \
class="diff" id="added">+ KeSetEvent(&<span \
id="addedchars">Writer</span>Fcb->Event, IO_NO_INCREMENT, FALSE); </pre><pre \
class="diff" id="context"> break; }
}
@@ -211,11 +172,11 @@
</pre><pre class="diff" id="context"> DPRINT("Message mode\n");
/* Message mode */
</pre><pre class="diff" id="removed">- if (<span \
id="removedchars">Read</span>Fcb->ReadDataAvailable) </pre><pre class="diff" \
id="added">+ if (Fcb->ReadDataAvailable) </pre><pre class="diff" \
id="context"> { /* Truncate the message if the \
receive buffer is too small */ </pre><pre class="diff" id="removed">- \
CopyLength = RtlRosMin(ReadFcb->ReadDataAvailable, Length);
- <span id="removedchars">memcpy(Buffer, ReadFcb->Data, \
Copy</span>Length); </pre><pre class="diff" id="added">+ <span \
id="addedchars">CopyLength = RtlRosMin(Fcb->ReadDataAvailable, </span>Length); + \
memcpy(Buffer, Fcb->Data, CopyLength); </pre><pre class="diff" \
id="context"> #ifndef NDEBUG
DPRINT("Length %d Buffer %x\n",CopyLength,Buffer);
@@ -223,28 +184,19 @@
</pre><pre class="diff" id="context"> #endif
Information = CopyLength;
</pre><pre class="diff" id="removed">- \
ReadFcb->ReadDataAvailable = 0;
- <span id="removedchars">ReadFcb->WriteQuotaAvailable = \
ReadFcb->MaxDataLength</span>; </pre><pre class="diff" id="added">+ \
<span id="addedchars">Fcb->ReadDataAvailable = 0</span>; + \
Fcb->WriteQuotaAvailable = Fcb->MaxDataLength; </pre><pre class="diff" \
id="context"> }
if (Information > 0)
{
</pre><pre class="diff" id="removed">- KeSetEvent(&<span \
id="removedchars">Read</span>Fcb->Event, IO_NO_INCREMENT, FALSE); </pre><pre \
class="diff" id="added">+ KeSetEvent(&<span \
id="addedchars">Writer</span>Fcb->Event, IO_NO_INCREMENT, FALSE); </pre><pre \
class="diff" id="context"> break; }
}
</pre><pre class="diff" id="removed">-
-#ifdef FIN_WORKAROUND_READCLOSE
- if (ReadFcb->ReadDataAvailable == 0 &&
- ReadFcb->PipeState == FILE_PIPE_CLOSING_STATE)
- {
- DPRINT("Other end of pipe is closed!\n");
- break;
- }
-#endif
</pre><pre class="diff" id="context"> }
</pre><pre class="diff" id="removed">- KeReleaseSpinLock(&<span \
id="removedchars">Read</span>Fcb->DataListLock, OldIrql); </pre><pre class="diff" \
id="added">+ KeReleaseSpinLock(&Fcb->DataListLock, OldIrql); </pre><pre \
class="diff" id="context"> done:
Irp->IoStatus.Status = Status;
@@ -265,6 +217,7 @@
</pre><pre class="diff" id="context"> PIO_STACK_LOCATION IoStack;
PFILE_OBJECT FileObject;
PNPFS_FCB Fcb = NULL;
</pre><pre class="diff" id="added">+ PNPFS_FCB ReaderFcb;
</pre><pre class="diff" id="context"> PNPFS_PIPE Pipe = NULL;
PUCHAR Buffer;
NTSTATUS Status = STATUS_SUCCESS;
@@ -283,6 +236,7 @@
</pre><pre class="diff" id="context"> DPRINT("Pipe name %wZ\n", \
&FileObject->FileName);
Fcb = FileObject->FsContext;
</pre><pre class="diff" id="added">+ ReaderFcb = Fcb->OtherSide;
</pre><pre class="diff" id="context"> Pipe = Fcb->Pipe;
Length = IoStack->Parameters.Write.Length;
@@ -297,7 +251,7 @@
</pre><pre class="diff" id="context"> goto done;
}
</pre><pre class="diff" id="removed">- if (<span \
id="removedchars">Fcb->OtherSide</span> == NULL) </pre><pre class="diff" \
id="added">+ if (<span id="addedchars">ReaderFcb</span> == NULL) </pre><pre \
class="diff" id="context"> { DPRINT("Pipe is \
NOT connected!\n"); if (Fcb->PipeState == \
FILE_PIPE_LISTENING_STATE) @@ -310,7 +264,7 @@
</pre><pre class="diff" id="context"> goto done;
}
</pre><pre class="diff" id="removed">- if (Fcb->Data == NULL)
</pre><pre class="diff" id="added">+ if (<span \
id="addedchars">Reader</span>Fcb->Data == NULL) </pre><pre class="diff" \
id="context"> { DPRINT("Pipe is NOT \
writable!\n"); Status = STATUS_UNSUCCESSFUL;
@@ -321,7 +275,7 @@
</pre><pre class="diff" id="context"> Status = STATUS_SUCCESS;
Buffer = MmGetSystemAddressForMdl (Irp->MdlAddress);
</pre><pre class="diff" id="removed">- \
KeAcquireSpinLock(&Fcb->DataListLock, &OldIrql); </pre><pre \
class="diff" id="added">+ KeAcquireSpinLock(&<span \
id="addedchars">Reader</span>Fcb->DataListLock, &OldIrql); </pre><pre \
class="diff" id="context"> #ifndef NDEBUG DPRINT("Length %d Buffer %x \
Offset %x\n",Length,Buffer,Offset); HexDump(Buffer, Length);
@@ -329,11 +283,11 @@
</pre><pre class="diff" id="context">
while(1)
{
</pre><pre class="diff" id="removed">- if \
(Fcb->WriteQuotaAvailable == 0) </pre><pre class="diff" id="added">+ \
if (<span id="addedchars">Reader</span>Fcb->WriteQuotaAvailable == 0) \
</pre><pre class="diff" id="context"> { KeResetEvent(&Fcb->Event);
</pre><pre class="diff" id="removed">- \
KeSetEvent(&Fcb->OtherSide->Event, IO_NO_INCREMENT, \
FALSE);
- Ke<span id="removedchars">ReleaseSpinLock(&Fcb->DataListLock, \
OldIrql</span>); </pre><pre class="diff" id="added">+ Ke<span \
id="addedchars">SetEvent(&ReaderFcb->Event, IO_NO_INCREMENT, FALSE</span>); + \
KeReleaseSpinLock(&ReaderFcb->DataListLock, OldIrql); </pre><pre \
class="diff" id="context"> if (Fcb->PipeState != \
FILE_PIPE_CONNECTED_STATE) {
Status = STATUS_PIPE_BROKEN;
@@ -348,7 +302,6 @@
</pre><pre class="diff" id="context"> NULL);
DPRINT("Finished waiting (%S)! Status: %x\n", \
Pipe->PipeName.Buffer, Status);
</pre><pre class="diff" id="removed">-#ifndef FIN_WORKAROUND_READCLOSE
</pre><pre class="diff" id="context"> /*
* It's possible that the event was signaled because the
* other side of pipe was closed.
@@ -359,44 +312,43 @@
</pre><pre class="diff" id="context"> Status = \
STATUS_PIPE_BROKEN; goto done;
}
</pre><pre class="diff" id="removed">-#endif
- KeAcquireSpinLock(&Fcb->DataListLock, &OldIrql);
</pre><pre class="diff" id="added">+ KeAcquireSpinLock(&<span \
id="addedchars">Reader</span>Fcb->DataListLock, &OldIrql); </pre><pre \
class="diff" id="context"> }
if (Pipe->WriteMode == FILE_PIPE_BYTE_STREAM_MODE)
{
DPRINT("Byte stream mode\n");
</pre><pre class="diff" id="removed">- while (Length > 0 && \
Fcb->WriteQuotaAvailable > 0) </pre><pre class="diff" id="added">+ while \
(Length > 0 && <span \
id="addedchars">Reader</span>Fcb->WriteQuotaAvailable > 0) </pre><pre \
class="diff" id="context"> { </pre><pre class="diff" id="removed">- \
CopyLength = RtlRosMin(Length, \
Fcb->WriteQuotaAvailable);
- <span id="removedchars">if (Fcb->WritePtr + CopyLength \
<= Fcb->Data + Fcb->MaxDataLength)</span> </pre><pre class="diff" \
id="added">+ <span id="addedchars">CopyLength = \
RtlRosMin(Length, ReaderFcb->WriteQuotaAvailable);</span> + \
if (ReaderFcb->WritePtr + CopyLength <= ReaderFcb->Data + \
ReaderFcb->MaxDataLength) </pre><pre class="diff" id="context"> {
</pre><pre class="diff" id="removed">- memcpy(Fcb->WritePtr, Buffer, \
CopyLength);
- Fcb->WritePtr += CopyLength;
- <span id="removedchars">if (Fcb->WritePtr == Fcb->Data + \
Fcb->MaxDataLength)</span> </pre><pre class="diff" id="added">+ <span \
id="addedchars">memcpy(ReaderFcb->WritePtr, Buffer, CopyLength);</span> + \
ReaderFcb->WritePtr += CopyLength; + if (ReaderFcb->WritePtr == \
ReaderFcb->Data + ReaderFcb->MaxDataLength) </pre><pre class="diff" \
id="context"> { </pre><pre class="diff" id="removed">- \
<span id="removedchars">Fcb->WritePtr = </span>Fcb->Data; \
</pre><pre class="diff" id="added">+ <span \
id="addedchars">ReaderFcb->WritePtr = Reader</span>Fcb->Data; </pre><pre \
class="diff" id="context"> } }
else
{
</pre><pre class="diff" id="removed">- TempLength = Fcb->Data + \
Fcb->MaxDataLength - Fcb->WritePtr;
- memcpy(Fcb->WritePtr, Buffer, TempLength);
- memcpy(Fcb->Data, Buffer + TempLength, CopyLength - TempLength);
- <span id="removedchars">Fcb->WritePtr = Fcb->Data + CopyLength - \
TempLength</span>; </pre><pre class="diff" id="added">+ <span \
id="addedchars">TempLength = ReaderFcb->Data + ReaderFcb->MaxDataLength - \
ReaderFcb->WritePtr</span>; + memcpy(ReaderFcb->WritePtr, Buffer, \
TempLength); + memcpy(ReaderFcb->Data, Buffer + TempLength, CopyLength - \
TempLength); + ReaderFcb->WritePtr = ReaderFcb->Data + CopyLength - \
TempLength; </pre><pre class="diff" id="context"> }
Buffer += CopyLength;
Length -= CopyLength;
Information += CopyLength;
</pre><pre class="diff" id="removed">- Fcb->ReadDataAvailable \
+= CopyLength;
- <span id="removedchars">Fcb->WriteQuotaAvailable -</span>= \
CopyLength; </pre><pre class="diff" id="added">+ <span \
id="addedchars">ReaderFcb->ReadDataAvailable +</span>= CopyLength; + \
ReaderFcb->WriteQuotaAvailable -= CopyLength; </pre><pre class="diff" \
id="context"> }
if (Length == 0)
{
</pre><pre class="diff" id="removed">- KeSetEvent(&<span \
id="removedchars">Fcb->OtherSide</span>->Event, IO_NO_INCREMENT, FALSE); \
</pre><pre class="diff" id="added">+ KeSetEvent(&<span \
id="addedchars">ReaderFcb</span>->Event, IO_NO_INCREMENT, FALSE); </pre><pre \
class="diff" id="context"> break; }
}
@@ -405,23 +357,23 @@
</pre><pre class="diff" id="context"> DPRINT("Message mode\n");
if (Length > 0)
{
</pre><pre class="diff" id="removed">- CopyLength = \
RtlRosMin(Length, Fcb->WriteQuotaAvailable);
- <span id="removedchars">memcpy(Fcb->Data, Buffer, \
CopyLength</span>); </pre><pre class="diff" id="added">+ <span \
id="addedchars">CopyLength = RtlRosMin(Length, \
ReaderFcb->WriteQuotaAvailable</span>); + \
memcpy(ReaderFcb->Data, Buffer, CopyLength); </pre><pre class="diff" \
id="context"> Information = CopyLength;
</pre><pre class="diff" id="removed">- Fcb->ReadDataAvailable \
= CopyLength;
- <span id="removedchars">Fcb->WriteQuotaAvailable = \
0</span>; </pre><pre class="diff" id="added">+ <span \
id="addedchars">ReaderFcb->ReadDataAvailable = CopyLength</span>; + \
ReaderFcb->WriteQuotaAvailable = 0; </pre><pre class="diff" id="context"> \
}
if (Information > 0)
{
</pre><pre class="diff" id="removed">- KeSetEvent(&<span \
id="removedchars">Fcb->OtherSide</span>->Event, IO_NO_INCREMENT, FALSE); \
</pre><pre class="diff" id="added">+ KeSetEvent(&<span \
id="addedchars">ReaderFcb</span>->Event, IO_NO_INCREMENT, FALSE); </pre><pre \
class="diff" id="context"> break; }
}
}
</pre><pre class="diff" id="removed">- \
KeReleaseSpinLock(&Fcb->DataListLock, OldIrql); </pre><pre class="diff" \
id="added">+ KeReleaseSpinLock(&<span \
id="addedchars">Reader</span>Fcb->DataListLock, OldIrql); </pre><pre class="diff" \
id="context"> done:
Irp->IoStatus.Status = Status;
</pre></div>
<hr /><div class="file">
<div class="fileheader"><big><b>Modified: \
trunk/reactos/drivers/fs/np/volume.c</b></big></div> <pre class="diff"><small \
id="info">--- trunk/reactos/drivers/fs/np/volume.c 2005-02-26 23:22:48 UTC (rev \
13762)
+++ trunk/reactos/drivers/fs/np/volume.c 2005-02-27 12:43:37 UTC (rev 13763)
@@ -2,9 +2,9 @@
</small></pre><pre class="diff" id="context"> *
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
</pre><pre class="diff" id="removed">- * FILE: \
<span id="removedchars">service</span>s/fs/npfs/volume.c </pre><pre \
class="diff" id="added">+ * FILE: <span \
id="addedchars">driver</span>s/fs/npfs/volume.c </pre><pre class="diff" id="context"> \
* PURPOSE: Named pipe filesystem </pre><pre \
class="diff" id="removed">- * PROGRAMMER: Eric Kohl<span \
id="removedchars"> <ekohl@rz-online.de></span> </pre><pre class="diff" \
id="added">+ * PROGRAMMER: Eric Kohl </pre><pre class="diff" \
id="context"> */
/* INCLUDES *****************************************************************/
@@ -23,20 +23,20 @@
</pre><pre class="diff" id="context"> \
NpfsQueryFsDeviceInformation(PFILE_FS_DEVICE_INFORMATION FsDeviceInfo, \
PULONG BufferLength) {
</pre><pre class="diff" id="removed">- \
DPRINT("NpfsQueryFsDeviceInformation()\n");
- DPRINT("FsDeviceInfo = %p\n", FsDeviceInfo);
-
- if (*BufferLength < sizeof(FILE_FS_DEVICE_INFORMATION))
- return(STATUS_BUFFER_OVERFLOW);
-
- FsDeviceInfo->DeviceType = FILE_DEVICE_NAMED_PIPE;
- FsDeviceInfo->Characteristics = 0;
-
- *BufferLength -= sizeof(FILE_FS_DEVICE_INFORMATION);
-
- DPRINT("NpfsQueryFsDeviceInformation() finished.\n");
-
- <span id="removedchars"> return(STATUS_SUCCESS</span>);
</pre><pre class="diff" id="added">+ <span \
id="addedchars">DPRINT("NpfsQueryFsDeviceInformation()\n"</span>); + \
DPRINT("FsDeviceInfo = %p\n", FsDeviceInfo); +
+ if (*BufferLength < sizeof(FILE_FS_DEVICE_INFORMATION))
+ return STATUS_BUFFER_OVERFLOW;
+
+ FsDeviceInfo->DeviceType = FILE_DEVICE_NAMED_PIPE;
+ FsDeviceInfo->Characteristics = 0;
+
+ *BufferLength -= sizeof(FILE_FS_DEVICE_INFORMATION);
+
+ DPRINT("NpfsQueryFsDeviceInformation() finished.\n");
+
+ return STATUS_SUCCESS;
</pre><pre class="diff" id="context"> }
@@ -44,22 +44,22 @@
</pre><pre class="diff" id="context"> \
NpfsQueryFsAttributeInformation(PFILE_FS_ATTRIBUTE_INFORMATION FsAttributeInfo, \
PULONG BufferLength) {
</pre><pre class="diff" id="removed">- \
DPRINT("NpfsQueryFsAttributeInformation() called.\n");
- DPRINT("FsAttributeInfo = %p\n", FsAttributeInfo);
-
- if (*BufferLength < sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8)
- return(STATUS_BUFFER_OVERFLOW);
-
- FsAttributeInfo->FileSystemAttributes = FILE_CASE_PRESERVED_NAMES;
- FsAttributeInfo->MaximumComponentNameLength = 255;
- FsAttributeInfo->FileSystemNameLength = 8;
- wcscpy(FsAttributeInfo->FileSystemName,
- L"NPFS");
-
- DPRINT("NpfsQueryFsAttributeInformation() finished.\n");
- *BufferLength -= (sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8);
-
- <span id="removedchars"> return(STATUS_SUCCESS</span>);
</pre><pre class="diff" id="added">+ <span \
id="addedchars">DPRINT("NpfsQueryFsAttributeInformation() \
called.\n"</span>); + DPRINT("FsAttributeInfo = %p\n", \
FsAttributeInfo); +
+ if (*BufferLength < sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8)
+ return STATUS_BUFFER_OVERFLOW;
+
+ FsAttributeInfo->FileSystemAttributes = FILE_CASE_PRESERVED_NAMES;
+ FsAttributeInfo->MaximumComponentNameLength = 255;
+ FsAttributeInfo->FileSystemNameLength = 8;
+ wcscpy(FsAttributeInfo->FileSystemName,
+ L"NPFS");
+
+ DPRINT("NpfsQueryFsAttributeInformation() finished.\n");
+ *BufferLength -= (sizeof(FILE_FS_ATTRIBUTE_INFORMATION) + 8);
+
+ return STATUS_SUCCESS;
</pre><pre class="diff" id="context"> }
@@ -67,54 +67,53 @@
</pre><pre class="diff" id="context"> NpfsQueryVolumeInformation(PDEVICE_OBJECT \
DeviceObject, PIRP Irp)
{
</pre><pre class="diff" id="removed">- PIO_STACK_LOCATION Stack;
- FS_INFORMATION_CLASS FsInformationClass;
- NTSTATUS Status = STATUS_SUCCESS;
- PVOID SystemBuffer;
- ULONG BufferLength;
-
- /* PRECONDITION */
- assert(DeviceObject != NULL);
- assert(Irp != NULL);
-
- DPRINT("NpfsQueryVolumeInformation(DeviceObject %x, Irp %x)\n",
- DeviceObject,
- Irp);
-
- Stack = IoGetCurrentIrpStackLocation (Irp);
- FsInformationClass = Stack->Parameters.QueryVolume.FsInformationClass;
- BufferLength = Stack->Parameters.QueryVolume.Length;
- SystemBuffer = Irp->AssociatedIrp.SystemBuffer;
-
- DPRINT("FsInformationClass %d\n", FsInformationClass);
- DPRINT("SystemBuffer %x\n", SystemBuffer);
-
- switch (FsInformationClass)
- {
- case FileFsDeviceInformation:
- Status = NpfsQueryFsDeviceInformation(SystemBuffer,
- &BufferLength);
- break;
-
- case FileFsAttributeInformation:
- Status = NpfsQueryFsAttributeInformation(SystemBuffer,
- &BufferLength);
- break;
-
- default:
- Status = STATUS_NOT_SUPPORTED;
- }
-
- Irp->IoStatus.Status = Status;
- if (NT_SUCCESS(Status))
- Irp->IoStatus.Information =
- Stack->Parameters.QueryVolume.Length - BufferLength;
- else
- Irp->IoStatus.Information = 0;
- IoCompleteRequest(Irp,
- IO_NO_INCREMENT);
-
- <span id="removedchars"> return(Status)</span>;
</pre><pre class="diff" id="added">+ <span id="addedchars">PIO_STACK_LOCATION \
Stack</span>; + FS_INFORMATION_CLASS FsInformationClass;
+ NTSTATUS Status = STATUS_SUCCESS;
+ PVOID SystemBuffer;
+ ULONG BufferLength;
+
+ /* PRECONDITION */
+ ASSERT(DeviceObject != NULL);
+ ASSERT(Irp != NULL);
+
+ DPRINT("NpfsQueryVolumeInformation(DeviceObject %x, Irp %x)\n",
+ DeviceObject,
+ Irp);
+
+ Stack = IoGetCurrentIrpStackLocation(Irp);
+ FsInformationClass = Stack->Parameters.QueryVolume.FsInformationClass;
+ BufferLength = Stack->Parameters.QueryVolume.Length;
+ SystemBuffer = Irp->AssociatedIrp.SystemBuffer;
+
+ DPRINT("FsInformationClass %d\n", FsInformationClass);
+ DPRINT("SystemBuffer %x\n", SystemBuffer);
+
+ switch (FsInformationClass)
+ {
+ case FileFsDeviceInformation:
+ Status = NpfsQueryFsDeviceInformation(SystemBuffer,
+ &BufferLength);
+ break;
+
+ case FileFsAttributeInformation:
+ Status = NpfsQueryFsAttributeInformation(SystemBuffer,
+ &BufferLength);
+ break;
+
+ default:
+ Status = STATUS_NOT_SUPPORTED;
+ }
+
+ Irp->IoStatus.Status = Status;
+ if (NT_SUCCESS(Status))
+ Irp->IoStatus.Information = Stack->Parameters.QueryVolume.Length \
- BufferLength; + else
+ Irp->IoStatus.Information = 0;
+ IoCompleteRequest(Irp,
+ IO_NO_INCREMENT);
+
+ return Status;
</pre><pre class="diff" id="context"> }
/* EOF */
</pre>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic