[prev in list] [next in list] [prev in thread] [next in thread]
List: ros-diffs
Subject: [ros-diffs] [CVS reactos] - Try to avoid crashing when dumping out
From: dwelch () osexperts ! com (David Welch)
Date: 2004-02-24 23:50:27
Message-ID: 20040224235027.5574443A9 () mok ! osexperts ! com
[Download RAW message or body]
<html>
<head>
<style><!--
body {background-color:#ffffff;}
.file {border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;}
.pathname {font-family:monospace; float:right;}
.fileheader {margin-bottom:.5em;}
.diff {margin:0;}
.tasklist {padding:4px;border:1px dashed #000000;margin-top:1em;}
.tasklist ul {margin-top:0;margin-bottom:0;}
tr.alt {background-color:#eeeeee}
#added {background-color:#ddffdd;}
#addedchars {background-color:#99ff99;font-weight:bolder;}
tr.alt #added {background-color:#ccf7cc;}
#removed {background-color:#ffdddd;}
#removedchars {background-color:#ff9999;font-weight:bolder;}
tr.alt #removed {background-color:#f7cccc;}
#info {color:#888888;}
#context {background-color:#eeeeee;}
td {padding-left:.3em;padding-right:.3em;}
tr.head {border-bottom-width:1px;border-bottom-style:solid;}
tr.head td {padding:0;padding-top:.2em;}
.task {background-color:#ffff00;}
.comment {padding:4px;border:1px dashed #000000;background-color:#ffffdd}
.error {color:red;}
hr {border-width:0px;height:2px;background:black;}
--></style>
</head>
<body>
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head"><td colspan="4">Commit in \
<b><tt>reactos/ntoskrnl/ke/i386</tt></b><span id="info"> on MAIN</span></td></tr> \
<tr><td><tt><a href="#file1">exp.c</a></tt></td><td align="right" \
id="added">+14</td><td align="right" id="removed">-2</td><td nowrap="nowrap" \
align="center"><a href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386/exp.c?rev=1.80&content-type=text/x-cvsweb-markup">1.80</a> \
<a href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386/exp.c.diff?r1=text&tr1=1.80&r2=text&tr2=1.81&f=h">-></a> \
<a href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386/exp.c?rev=1.81&content-type=text/x-cvsweb-markup">1.81</a></td></tr>
</table>
<pre class="comment">
- Try to avoid crashing when dumping out a corrupted stack.
</pre>
<hr /><a name="file1" /><div class="file">
<span class="pathname"><a \
href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos">reactos</a>/<a \
href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl">ntoskrnl</a>/<a \
href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke">ke</a>/<a \
href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386">i386</a><br \
/></span> <div class="fileheader"><big><b>exp.c</b></big> <small id="info"><a \
href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386/exp.c?rev=1.80&content-type=text/x-cvsweb-markup">1.80</a> \
<a href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386/exp.c.diff?r1=text&tr1=1.80&r2=text&tr2=1.81&f=h">-></a> \
<a href="http://cvs.reactos.com/cgi-bin/cvsweb/reactos/ntoskrnl/ke/i386/exp.c?rev=1.81&content-type=text/x-cvsweb-markup">1.81</a></small></div>
<pre class="diff"><small id="info">diff -u -r1.80 -r1.81
--- exp.c 13 Jan 2004 03:23:11 -0000 1.80
+++ exp.c 24 Feb 2004 23:50:26 -0000 1.81
@@ -500,8 +500,20 @@
</small></pre><pre class="diff" id="context"> Frame = (PULONG)Tf->Ebp;
while (Frame != NULL)
{
</pre><pre class="diff" id="removed">- print_address((PVOID)Frame[1]);
- Frame = (PULONG)Frame[0];
</pre><pre class="diff" id="added">+ NTSTATUS Status;
+ PVOID Eip;
+ Status = MmSafeCopyFromUser(&Eip, Frame + 1, sizeof(Eip));
+ if (!NT_SUCCESS(Status))
+ {
+ DbgPrint("<INVALID>");
+ break;
+ }
+ print_address(Eip);
+ Status = MmSafeCopyFromUser(&Frame, Frame, sizeof(Frame));
+ if (!NT_SUCCESS(Status))
+ {
+ break;
+ }
</pre><pre class="diff" id="context"> i++;
DbgPrint(" ");
}
</pre></div>
<center><small><a href="http://www.badgers-in-foil.co.uk/projects/cvsspam/" \
title="commit -> email">CVSspam</a> 0.2.8</small></center> </body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic