[prev in list] [next in list] [prev in thread] [next in thread]
List: ros-dev
Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35600: - Remove KEBUGCHECK
From: Stefan Ginsberg <stefan__100__ () hotmail ! com>
Date: 2008-08-26 13:37:03
Message-ID: BAY121-W21CEE44596308574015911F5660 () phx ! gbl
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hello
Yes, I do know that ASSERT(FALSE) only occur in debug mode. However, I think this \
change is safe. Many of the KEBUGCHECK(0) usages are for unimplemented or very rare \
cases which shouldn't be hit, and the largest use of KEBUGCHECK(0) was in Mm (and the \
worst that could happen there is that ros survives a little longer).
Anyway, I will look into re-adding KeBugCheck with proper bugcodes where appropriate.
> Date: Sun, 24 Aug 2008 20:15:38 +0200
> From: hpoussin@reactos.org
> To: ros-dev@reactos.org
> Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35600: - Remove KEBUGCHECK and \
> KEBUGCHECKEX macros - Replace "KeBugCheck(0)" by ASSERT(FALSE) - Replace deprecated \
> "CPRINT" by DRINT1
> sginsberg@svn.reactos.org a écrit :
> > Author: sginsberg
> > Date: Sun Aug 24 10:48:05 2008
> > New Revision: 35600
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=35600&view=rev
> > Log:
> > - Remove KEBUGCHECK and KEBUGCHECKEX macros
> > - Replace "KeBugCheck(0)" by ASSERT(FALSE)
> > - Replace deprecated "CPRINT" by DRINT1
> >
>
> You probably understand that KEBUGCHECK(0) is *NOT* the same as
> ASSERT(FALSE)
>
> ASSERT(FALSE) is valid only in debug mode, and lets the code continue in
> release mode.
> KEBUGCHECK stops the execution also in release mode.
>
> For example, in ntoskrnl/dbgk/dbgkobj.c, code now continues even if
> DbgkpQueueMessage failed. Are you sure it is safe to continue in that case?
> (same question applies for other locations)
>
> Hervé
> _______________________________________________
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
_________________________________________________________________
Discover the new Windows Vista
http://search.msn.com/results.aspx?q=windows+vista&mkt=en-US&form=QBRE
[Attachment #5 (text/html)]
<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'>
Hello<br><br>Yes, I do know that ASSERT(FALSE) only occur in debug mode. However, I \
think this change is safe. Many of the KEBUGCHECK(0) usages are for unimplemented or \
very rare cases which shouldn't be hit, and the largest use of KEBUGCHECK(0) was in \
Mm (and the worst that could happen there is that ros survives a little \
longer).<br><br>Anyway, I will look into re-adding KeBugCheck with proper bugcodes \
where appropriate.<br><br><br><br>> Date: Sun, 24 Aug 2008 20:15:38 +0200<br>> \
From: hpoussin@reactos.org<br>> To: ros-dev@reactos.org<br>> Subject: Re: \
[ros-dev] [ros-diffs] [sginsberg] 35600: - Remove KEBUGCHECK and KEBUGCHECKEX macros \
- Replace "KeBugCheck(0)" by ASSERT(FALSE) - Replace deprecated "CPRINT" by \
DRINT1<br>> <br>> sginsberg@svn.reactos.org a écrit :<br>> > Author: \
sginsberg<br>> > Date: Sun Aug 24 10:48:05 2008<br>> > New Revision: \
35600<br>> > <br>> > URL: \
http://svn.reactos.org/svn/reactos?rev=35600&view=rev<br>> > Log:<br>> \
> - Remove KEBUGCHECK and KEBUGCHECKEX macros<br>> > - Replace \
"KeBugCheck(0)" by ASSERT(FALSE)<br>> > - Replace deprecated "CPRINT" by \
DRINT1<br>> > <br>> <br>> You probably understand that KEBUGCHECK(0) is \
*NOT* the same as <br>> ASSERT(FALSE)<br>> <br>> ASSERT(FALSE) is valid only \
in debug mode, and lets the code continue in <br>> release mode.<br>> \
KEBUGCHECK stops the execution also in release mode.<br>> <br>> For example, in \
ntoskrnl/dbgk/dbgkobj.c, code now continues even if <br>> DbgkpQueueMessage \
failed. Are you sure it is safe to continue in that case?<br>> (same question \
applies for other locations)<br>> <br>> Hervé<br>> \
_______________________________________________<br>> Ros-dev mailing list<br>> \
Ros-dev@reactos.org<br>> http://www.reactos.org/mailman/listinfo/ros-dev<br><br \
/><hr />Discover the new Windows Vista <a \
href='http://search.msn.com/results.aspx?q=windows+vista&mkt=en-US&form=QBRE' \
target='_new'>Learn more!</a></body> </html>
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic