[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-dev
Subject:    Re: barrywardell: r12838 - trunk/firmware/common
From:       "Barry Wardell" <barry.wardell () gmail ! com>
Date:       2007-03-20 10:44:49
Message-ID: c17ec4060703200344j595c71dq67a137154771b66d () mail ! gmail ! com
[Download RAW message or body]

Committed to SVN. Thanks for the tip.

Barry

On 3/19/07, Magnus Holmgren <lear@algonet.se> wrote:
> Barry Wardell wrote:
>
> >> Should it really modify the input string like that? What if it is in
> >> flash? (Might not be a problem as currently used, but...)
> >>
> >>    Magnus
> >>
> >>
> > Good point. Would this be a better way to do it:
>
> <...>
>
> > @@ -160,7 +161,7 @@
> >         while (width-- > 0 && ok)
> >             ok=push(userp, pad);
> >         }
> > -        while (*str != '\0' && ok)
> > +        while (*str != '\0' && ok && precision--)
> >                 ok=push(userp, *str++);
> >     }
>
> Yes, that looks like a good solution.
>
>    Magnus
>

[prev in list] [next in list] [prev in thread] [next in thread]