[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-cvs
Subject:    Playlist Viewer:  Don't set unmodified after saving
From:       rockbox-gerrit-noreply--- via rockbox-cvs <rockbox-cvs () lists ! haxx ! se>
Date:       2023-10-28 23:33:16
Message-ID: 202310282333.39SNXG6G1448089 () archos ! rockbox ! org
[Download RAW message or body]

commit 954dd0ff758b7ec95e387cca9124529c63339791
Author: Christian Soffke <christian.soffke@gmail.com>
Date:   Sun Oct 29 01:21:53 2023 +0200

    Playlist Viewer:  Don't set unmodified after saving
    
    90e3571 has made this redundant
    
    Change-Id: Ic5cc374712d5eddfd4bd53ed083fa9ec2c5777c6

diff --git a/apps/playlist_viewer.c b/apps/playlist_viewer.c
index 8219aa5feb..608a90340e 100644
--- a/apps/playlist_viewer.c
+++ b/apps/playlist_viewer.c
@@ -658,15 +658,7 @@ static enum pv_onplay_result onplay_menu(int index)
                 ret = PV_ONPLAY_CHANGED;
                 break;
             case 6:
-                /* save playlist */
-                if (!save_playlist_screen(viewer.playlist) && viewer.playlist)
-                    /*
-                     * Set unmodified unless it's the current playlist, which may
-                     * contain queued songs that aren't saved to the playlist file
-                     * TODO: This can be removed once g5192 is merged,
-                     *       "playlist: Rewrite playlist_save(), optimization & fixes"
-                     */
-                    playlist_set_modified(viewer.playlist, false);
+                save_playlist_screen(viewer.playlist);
                 ret = PV_ONPLAY_UNCHANGED;
                 break;
             case 7:
-- 
rockbox-cvs mailing list
rockbox-cvs@lists.haxx.se
https://lists.haxx.se/mailman/listinfo/rockbox-cvs
[prev in list] [next in list] [prev in thread] [next in thread]