[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-cvs
Subject:    plugin sliding puzzle fix unneeded check
From:       rockbox-gerrit-noreply--- via rockbox-cvs <rockbox-cvs () lists ! haxx ! se>
Date:       2022-06-22 2:27:52
Message-ID: 202206220227.25M2RqcW1401120 () archos ! rockbox ! org
[Download RAW message or body]

commit e75e07e1b68b5ce59b0a77f321c90a091682e362
Author: William Wilgus <wilgus.william@gmail.com>
Date:   Tue Jun 21 22:22:50 2022 -0400

    plugin sliding puzzle fix unneeded check
    
    Change-Id: Iab345d2ec490311fc8a5482c52dbed14f5e11070

diff --git a/apps/plugins/sliding_puzzle.c b/apps/plugins/sliding_puzzle.c
index a34cb77669..af6aa40ea0 100644
--- a/apps/plugins/sliding_puzzle.c
+++ b/apps/plugins/sliding_puzzle.c
@@ -468,8 +468,8 @@ static const char * initial_bmp_path=NULL;
 static const char * get_albumart_bmp_path(void)
 {
     struct mp3entry* track = rb->audio_current_track();
-
-    if (!track || !track->path || track->path[0] == '\0')
+    /* Note rb->audio_current_track->path should never be null */
+    if (!track || track->path[0] == '\0')
         return NULL;
 
     if (!rb->search_albumart_files(track, "", albumart_path, MAX_PATH ) )
-- 
rockbox-cvs mailing list
rockbox-cvs@lists.haxx.se
https://lists.haxx.se/listinfo/rockbox-cvs
[prev in list] [next in list] [prev in thread] [next in thread]