[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-cvs
Subject:    Playlist Viewer: Always retrieve track Info from disk
From:       rockbox-gerrit-noreply--- via rockbox-cvs <rockbox-cvs () lists ! haxx ! se>
Date:       2022-04-17 14:58:46
Message-ID: 202204171458.23HEwkOc2672225 () archos ! rockbox ! org
[Download RAW message or body]

commit 6703f43f5cc6c6d2f4983aaafd4bcfd582b133cf
Author: Christian Soffke <christian.soffke@gmail.com>
Date:   Sun Apr 10 02:25:54 2022 +0200

    Playlist Viewer: Always retrieve track Info from disk
    
    Frequency, file size, and the codec are not stored
    in the database and thus can't be displayed in the
    Playlist Viewer's Track Info screen when metadata
    is only retrieved from the database.
    
    Change-Id: I9e1d11c13ad8bf7b90b654ed78e4e7f763c30f8a

diff --git a/apps/playlist_viewer.c b/apps/playlist_viewer.c
index 6ebac1cb41..a94e07643e 100644
--- a/apps/playlist_viewer.c
+++ b/apps/playlist_viewer.c
@@ -484,19 +484,12 @@ static int show_track_info(struct playlist_entry *current_track)
     struct mp3entry id3;
     bool id3_retrieval_successful = false;
 
-#if defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE)
-    if (tagcache_fill_tags(&id3, current_track->name))
-        id3_retrieval_successful = true;
-    else
-#endif
+    int fd = open(current_track->name, O_RDONLY);
+    if (fd >= 0)
     {
-        int fd = open(current_track->name, O_RDONLY);
-        if (fd >= 0)
-        {
-            if (get_metadata(&id3, fd, current_track->name))
-                id3_retrieval_successful = true;
-            close(fd);
-        }
+        if (get_metadata(&id3, fd, current_track->name))
+            id3_retrieval_successful = true;
+        close(fd);
     }
 
     return id3_retrieval_successful &&
-- 
rockbox-cvs mailing list
rockbox-cvs@lists.haxx.se
https://lists.haxx.se/listinfo/rockbox-cvs

[prev in list] [next in list] [prev in thread] [next in thread]