[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-cvs
Subject:    vibe 500: Fix ide_powered() always returning false
From:       gerrit () rockbox ! org
Date:       2014-12-20 13:15:06
Message-ID: 201412201315.sBKDF6Ql006389 () giant ! haxx ! se
[Download RAW message or body]

commit d62e1b3c5ff513fb69e784cbfb59dad1cc67899b
Author: Thomas Jarosch <tomj@simonv.com>
Date:   Sat Dec 20 13:57:54 2014 +0100

    vibe 500: Fix ide_powered() always returning false
    
    While the right GPIO location is accessed,
    the result of the logical AND was tested wrong.
    
    I don't have this hardware, but I can imagine
    that bug caused ide_power_enable() to be called
    more times than it needed to be.
    
    cppcheck reported:
    [rockbox/firmware/target/arm/pbell/vibe500/power-vibe500.c:101]: (style) \
Expression '(X & 0x8) == 0x1' is always false.  
    Change-Id: I98498f79d383c6f29869e170bfc94ba9a0d2ba7e

diff --git a/firmware/target/arm/pbell/vibe500/power-vibe500.c \
b/firmware/target/arm/pbell/vibe500/power-vibe500.c index e062ebd..6237f7e 100644
--- a/firmware/target/arm/pbell/vibe500/power-vibe500.c
+++ b/firmware/target/arm/pbell/vibe500/power-vibe500.c
@@ -98,7 +98,7 @@ void ide_power_enable(bool on)
 
 bool ide_powered(void)
 {
-    return ((GPIOC_INPUT_VAL & 0x08) == 1);
+    return ((GPIOC_INPUT_VAL & 0x08) != 0);
 }
 
 void power_off(void)
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs@cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs


[prev in list] [next in list] [prev in thread] [next in thread]