[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-cvs
Subject:    Make sure the USB PHY is disabled after use. Patch by Mihail Zenkov who has measured several milliam
From:       gerrit () rockbox ! org
Date:       2014-09-28 19:07:46
Message-ID: 201409281907.s8SJ7kvh009970 () giant ! haxx ! se
[Download RAW message or body]

commit 02414bf286e4ff6a08d19e951bff1e0905d330b4
Author: Mihail Zenkov <Mihail_Zenkov@rockbox.org>
Date:   Sat Sep 27 23:58:51 2014 +0200

    Make sure the USB PHY is disabled after use.  Patch by Mihail Zenkov who has
    measured several milliamps power reduction from having the PHY disabled.
    
    Change-Id: I29e55222eb50acf2023ac1113a90612029c580af
    Reviewed-on: http://gerrit.rockbox.org/988
    Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
    Tested: Michael Giacomelli <giac2000@hotmail.com>

diff --git a/docs/CREDITS b/docs/CREDITS
index 4b3b590..96a5b78 100644
--- a/docs/CREDITS
+++ b/docs/CREDITS
@@ -643,6 +643,7 @@ Yifu Huang
 Jonathan Bettencourt
 Ilia Sergachev
 Nial Shui
+Mihail Zenkov
 
 The libmad team
 The wavpack team
diff --git a/firmware/target/arm/usb-s3c6400x.c b/firmware/target/arm/usb-s3c6400x.c
index 48521aa..af4e564 100644
--- a/firmware/target/arm/usb-s3c6400x.c
+++ b/firmware/target/arm/usb-s3c6400x.c
@@ -354,6 +354,12 @@ void usb_drv_exit(void)
 
     CGU_USB = 0;
     bitclr32(&CGU_PERI, CGU_USB_CLOCK_ENABLE);
+
+    /* reset USB_PHY to prevent power consumption */
+    CCU_SRC = CCU_SRC_USB_PHY_EN;
+    CCU_SRL = CCU_SRL_MAGIC_NUMBER;
+    CCU_SRL = 0;
+
 }
 #elif CONFIG_CPU == S5L8701 || CONFIG_CPU == S5L8702
 static void usb_reset(void)
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs@cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic