[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rockbox-cvs
Subject:    Domonoky: r25401 - trunk/rbutil/rbutilqt
From:       mailer () svn ! rockbox ! org
Date:       2010-03-30 17:43:49
Message-ID: 201003301743.o2UHhnac027291 () giant ! haxx ! se
[Download RAW message or body]

Date: 2010-03-30 19:43:49 +0200 (Tue, 30 Mar 2010)
New Revision: 25401

Log Message:
Delete tts objects after use.

Author: Delyan Kratunov
Flyspray: FS#11155 part1

Modified:
   trunk/rbutil/rbutilqt/configure.cpp

Modified: trunk/rbutil/rbutilqt/configure.cpp
===================================================================
--- trunk/rbutil/rbutilqt/configure.cpp	2010-03-30 17:09:04 UTC (rev 25400)
+++ trunk/rbutil/rbutilqt/configure.cpp	2010-03-30 17:43:49 UTC (rev 25401)
@@ -403,6 +403,9 @@
         ui.configTTSstatus->setText(tr("Configuration INVALID"));
         ui.configTTSstatusimg->setPixmap(QPixmap(QString::fromUtf8(":/icons/dialog-error.png")));
  }
+    
+    delete tts; /* Config objects are never deleted (in fact, they are leaked..), so \
we can't rely on QObject, +                   since that would delete the TTSBase \
instance on application exit*/  }
 
 void Config::updateEncState()
@@ -699,6 +702,8 @@
     EncTtsCfgGui gui(this,tts,TTSBase::getTTSName(ui.comboTts->itemData(index).toString()));
  gui.exec();
     updateTtsState(ui.comboTts->currentIndex());
+    delete tts; /* Config objects are never deleted (in fact, they are leaked..), so \
we can't rely on QObject, +                   since that would delete the TTSBase \
instance on application exit*/  }
 
 void Config::testTts()
@@ -745,6 +750,9 @@
 #else
     QSound::play(filename);
 #endif
+    
+    delete tts; /* Config objects are never deleted (in fact, they are leaked..), so \
we can't rely on QObject, +                   since that would delete the TTSBase \
instance on application exit*/  }
 
 void Config::configEnc()

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs@cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs


[prev in list] [next in list] [prev in thread] [next in thread]