'Re: r5595 - /1.3/specific_fns/jw_mapping.py'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       relax-devel
Subject:    Re: r5595 - /1.3/specific_fns/jw_mapping.py
From:       Sébastien_Morin <sebastien.morin.1 () domain ! hid>
Date:       2008-04-12 20:52:23
Message-ID: 48012107.2020506 () domain ! hid
[Download RAW message or body]

Hi Ed,

That is something I really didn't know... I thought that arguments order 
was without importance...

Ok, I'll check if I've done this (ordering alphabetically) elsewhere.

Cheers !


Séb


Edward d'Auvergne wrote:
> On Sat, Apr 12, 2008 at 2:02 AM,  <sebastien.morin.1@domain.hid> wrote:
> 
> > Author: semor
> > Date: Sat Apr 12 02:02:23 2008
> > New Revision: 5595
> > 
> > URL: http://svn.gna.org/viewcvs/relax?rev=5595&view=rev
> > Log:
> > Added a missing argument to the set_error() method.
> > 
> > This omission was spotted by Edward d'Auvergne in a post at:
> > https://mail.gna.org/public/relax-devel/2008-04/msg00053.html (# Message-id:
> > <7f080ed10804111525p48f7bc6aq10189644ae5d736b@domain.hid>)
> > 
> > 
> > Modified:
> > 1.3/specific_fns/jw_mapping.py
> > 
> > Modified: 1.3/specific_fns/jw_mapping.py
> > URL: http://svn.gna.org/viewcvs/relax/1.3/specific_fns/jw_mapping.py?rev=5595&r1=5594&r2=5595&view=diff
> >  ==============================================================================
> > --- 1.3/specific_fns/jw_mapping.py (original)
> > +++ 1.3/specific_fns/jw_mapping.py Sat Apr 12 02:02:23 2008
> > @@ -402,7 +402,7 @@
> > cdp.jw_frq = frq
> > 
> > 
> > -    def set_error(self, spin, error):
> > +    def set_error(self, error, index, spin):
> > 
> 
> Here the function args should be
> 
> def set_error(self, spin, index, error)
> 
> This is very important as that is the order that the argments are sent
> the function.
> 
> Regards,
> 
> Edward
> 
> _______________________________________________
> relax (http://nmr-relax.com)
> 
> This is the relax-devel mailing list
> relax-devel@domain.hid
> 
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel
> 
> 


[Attachment #3 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Ed,<br>
<br>
That is something I really didn't know... I thought that arguments
order was without importance...<br>
<br>
Ok, I'll check if I've done this (ordering alphabetically) elsewhere.<br>
<br>
Cheers !<br>
<br>
<br>
S&eacute;b<br>
<br>
<br>
Edward d'Auvergne wrote:
<blockquote
 cite="mid:7f080ed10804121345n2a6116eaob66c3f9bc7f36cba@domain.hid"
 type="cite">
  <pre wrap="">On Sat, Apr 12, 2008 at 2:02 AM,  <a class="moz-txt-link-rfc2396E" \
href="mailto:sebastien.morin.1@domain.hid">&lt;sebastien.morin.1@domain.hid&gt;</a> \
wrote:  </pre>
  <blockquote type="cite">
    <pre wrap="">Author: semor
 Date: Sat Apr 12 02:02:23 2008
 New Revision: 5595

 URL: <a class="moz-txt-link-freetext" \
href="http://svn.gna.org/viewcvs/relax?rev=5595&view=rev">http://svn.gna.org/viewcvs/relax?rev=5595&amp;view=rev</a>
  Log:
 Added a missing argument to the set_error() method.

 This omission was spotted by Edward d'Auvergne in a post at:
 <a class="moz-txt-link-freetext" \
href="https://mail.gna.org/public/relax-devel/2008-04/msg00053.html">https://mail.gna.org/public/relax-devel/2008-04/msg00053.html</a> \
(# Message-id:  <a class="moz-txt-link-rfc2396E" \
href="mailto:7f080ed10804111525p48f7bc6aq10189644ae5d736b@domain.hid">&lt;7f080ed10804111525p48f7bc6aq10189644ae5d736b@domain.hid&gt;</a>)



 Modified:
    1.3/specific_fns/jw_mapping.py

 Modified: 1.3/specific_fns/jw_mapping.py
 URL: <a class="moz-txt-link-freetext" \
href="http://svn.gna.org/viewcvs/relax/1.3/specific_fns/jw_mapping.py?rev=5595&r1=5594 \
&r2=5595&view=diff">http://svn.gna.org/viewcvs/relax/1.3/specific_fns/jw_mapping.py?rev=5595&amp;r1=5594&amp;r2=5595&amp;view=diff</a>
  ==============================================================================
 --- 1.3/specific_fns/jw_mapping.py (original)
 +++ 1.3/specific_fns/jw_mapping.py Sat Apr 12 02:02:23 2008
 @@ -402,7 +402,7 @@
         cdp.jw_frq = frq


 -    def set_error(self, spin, error):
 +    def set_error(self, error, index, spin):
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Here the function args should be

def set_error(self, spin, index, error)

This is very important as that is the order that the argments are sent
the function.

Regards,

Edward

_______________________________________________
relax (<a class="moz-txt-link-freetext" \
href="http://nmr-relax.com">http://nmr-relax.com</a>)

This is the relax-devel mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:relax-devel@domain.hid">relax-devel@domain.hid</a>

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
<a class="moz-txt-link-freetext" \
href="https://mail.gna.org/listinfo/relax-devel">https://mail.gna.org/listinfo/relax-devel</a>


  </pre>
</blockquote>
</body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic