[prev in list] [next in list] [prev in thread] [next in thread] 

List:       reiserfs-devel
Subject:    Re: [PATCH] reiserfs: remove unused sched_count variable
From:       Jan Kara <jack () suse ! cz>
Date:       2023-03-27 8:57:49
Message-ID: 20230327085749.feyfegzdjxqhymdu () quack3
[Download RAW message or body]

On Sun 26-03-23 16:44:59, Tom Rix wrote:
> clang with W=1 reports
> fs/reiserfs/journal.c:3034:6: error: variable
>   'sched_count' set but not used [-Werror,-Wunused-but-set-variable]
>         int sched_count = 0;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Thanks. I've added the fix to my tree.

								Honza

> ---
>  fs/reiserfs/journal.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 9ce4ec296b74..4d11d60f493c 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -3031,7 +3031,6 @@ static int do_journal_begin_r(struct reiserfs_transaction_handle *th,
>  	unsigned int old_trans_id;
>  	struct reiserfs_journal *journal = SB_JOURNAL(sb);
>  	struct reiserfs_transaction_handle myth;
> -	int sched_count = 0;
>  	int retval;
>  	int depth;
>  
> @@ -3088,7 +3087,6 @@ static int do_journal_begin_r(struct reiserfs_transaction_handle *th,
>  		    ((journal->j_len + nblocks + 2) * 100) <
>  		    (journal->j_len_alloc * 75)) {
>  			if (atomic_read(&journal->j_wcount) > 10) {
> -				sched_count++;
>  				queue_log_writer(sb);
>  				goto relock;
>  			}
> -- 
> 2.27.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
[prev in list] [next in list] [prev in thread] [next in thread]