[prev in list] [next in list] [prev in thread] [next in thread] 

List:       reiserfs-devel
Subject:    Re: [patch 18/35 xattr-rework] reiserfs: Clean up xattrs when
From:       Christoph Hellwig <hch () infradead ! org>
Date:       2009-03-31 18:44:02
Message-ID: 20090331184402.GA28520 () infradead ! org
[Download RAW message or body]

On Mon, Mar 30, 2009 at 02:02:33PM -0400, Jeff Mahoney wrote:
>  The current reiserfs xattr implementation will not clean up old xattr
>  files if files are deleted when REISERFS_FS_XATTR is unset. This results
>  in inaccessible lost files, wasting space.
> 
>  This patch compiles in basic xattr knowledge, such as how to delete them and
>  change ownership for quota tracking. If the file system has never used
>  xattrs, then the operation is quite fast: it returns immediately when
>  it sees there is no .reiserfs_priv directory.

What about just making xattr suppose unconditional?  That's what most
never filesystems do, and it really shouldn't be a whole lot of code.

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]