[prev in list] [next in list] [prev in thread] [next in thread] 

List:       reiserfs-devel
Subject:    Re: [patch 1/2] reiser4: adjust to the new aops
From:       Nick Piggin <npiggin () suse ! de>
Date:       2008-11-27 14:48:11
Message-ID: 20081127144811.GS28285 () wotan ! suse ! de
[Download RAW message or body]

On Thu, Nov 27, 2008 at 05:34:26PM +0300, Edward Shishkin wrote:
> reiser4_write_{begin,end} works only in splice.c (i.e. only for
> loopback functionality) in the chunk of code which looks like this:
> 
> pagecache_write_begin();
> ...
> memcpy(.., to_page);
> ...
> pagecache_write_end(.., to_page, ..);
> 
> i.e. there can not be short writes and everything is uptodate.
 
Ah OK, indeed you are right. Although that's not to say that some
other kernel code may not be able to start doing interruptible
copies, although it would be fairly unlikely. Maybe if you just have
a BUG_ON(!(flags & AOP_FLAG_UNINTERRUPTIBLE)); or something to just
make sure?

> reiser4_write() has its own means to fight with short writes.
> Not everything is excellent here though, but this is another topic..

OK, well in that case, I don't see any problem with your patch.

Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]