[prev in list] [next in list] [prev in thread] [next in thread] 

List:       reiserfs-devel
Subject:    Re: [reiserfs-list] read(2) does not update st_atime
From:       Chris Mason <mason () suse ! com>
Date:       2002-02-22 21:21:09
[Download RAW message or body]



On Friday, February 22, 2002 10:03:29 PM +0100 Marek 'Marecki' Szuba
<cyberman@if.pw.edu.pl> wrote:

> On Fri, 22 Feb 2002, Shen, Lian wrote:
> 
>> It seems reiserfs does not update st_atime correctly (ext2 does well),
> Got exactly the same problem here with two boxes running 2.4.17
> (filesystems version 3.6, have been created with 2.4.6 or close to it),
> in fact I was about to ask about it as soon as I have time. It manifests
> in two ways: 1. My mail is Maildir-based; shadow password suite's new
> mail check for this type of inbox relies upon a difference between atime
> and mtime of Maildir/new. Unfortunately every time any user logs in
> he/she gets "You have new mail" (provided his/her Maildir exists of
> course) because atime never changes.

This patch should fix both problems:

--- linus.21/fs/reiserfs/dir.c Thu, 13 Dec 2001 11:06:51 -0500
+++ linus.21(w)/fs/reiserfs/dir.c Tue, 29 Jan 2002 17:56:04 -0500
@@ -180,6 +180,7 @@
     filp->f_pos = next_pos;
     pathrelse (&path_to_entry);
     reiserfs_check_path(&path_to_entry) ;
+    UPDATE_ATIME(inode) ;
     return 0;
 }
 

[prev in list] [next in list] [prev in thread] [next in thread]