[prev in list] [next in list] [prev in thread] [next in thread] 

List:       redhat-linux-cluster
Subject:    [Linux-cluster] [PATCH] Fix cman_get_node_id in qdisk.
From:       Simone Gotti <simone.gotti () email ! it>
Date:       2007-01-04 14:13:12
Message-ID: 1167919992.11659.14.camel () localhost
[Download RAW message or body]

Hi all,


testing the qdiskd provided by the new openais cman-2.0.35-2 (on RHEL5
Beta 2) I found that it would no start with the following error:

Could not determine local node ID; cannot start


Looking at the code of the other programs that connects to cman I
noticed that before the call libcman function:
cman_get_node(cman_handle_t handle, int nodeid, cman_node_t *node), 
they are inizialing with all zeros the third argument, so I did the same
with qdiskd and it worked.

Looking at the cvs repository I didn't find a fix for it.
A patch is attached. 

Thanks!

Bye!


-- 
Simone Gotti

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Refill srl il paradiso della tua stampante - cartucce e toner compatibili, \
inchiostri e accessori per la ricarica, carta speciale. Tutto a prezzi scontatissimi! \
Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=5187&d=4-1


["cman-2.0.35-qdisk-cman_get_node-fix.patch" (cman-2.0.35-qdisk-cman_get_node-fix.patch)]

diff -r -u -p cman-2.0.35/cman/qdisk/main.c cman-2.0.35.orig/cman/qdisk/main.c
--- cman-2.0.35/cman/qdisk/main.c	2006-10-03 20:06:40.000000000 +0200
+++ cman-2.0.35.orig/cman/qdisk/main.c	2007-01-04 17:13:18.000000000 +0100
@@ -957,6 +957,7 @@ main(int argc, char **argv)
 		return -1;
 	}
 
+	memset(&me, 0, sizeof(me));
 	if (cman_get_node(ch, CMAN_NODEID_US, &me) < 0) {
 		printf("Could not determine local node ID; cannot start\n");
 		return -1;


--
Linux-cluster mailing list
Linux-cluster@redhat.com
https://www.redhat.com/mailman/listinfo/linux-cluster

[prev in list] [next in list] [prev in thread] [next in thread]