[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rapidsvn-users
Subject:    Re: I would like to make some changes to rapidsvn
From:       Alexander Mueller <XelaRellum () web ! de>
Date:       2007-08-09 20:37:47
Message-ID: 46BB7B1B.4080400 () web ! de
[Download RAW message or body]

As you may have seen I have appliced the c) part of the patch.
I would like to separate parts a) and b) as well.

One thought about b): right now we do all the filtering once
we already have the data returned from Client::status. We could avoid 
this by actively filtering in Client::status.

This could be done either by adding a new parameter "flags" or whatever 
to Client::status with a selection of bit constants that make sense and 
pass these to the method.

Another way could be to pass the refernce to a StatusFilter class.
Everytime Client::status wants to add an entry to the vector it would 
first be passed to StatusFilter::check(const Status & status).

What do you think?

Xela


mgjg@mgjg.com schrieb:
> Coming from a wincvs environment I like using rapidsvn for managing my
> subversion repositories, but find that I would like the following
> features, and have attached changes to implement them.
> 
> a) intermingle folders and files in the flat view. I find that
> separating the folders from the files (which I admit is what Windows
> explorer does) just makes it harder to deal with entries which are
> logically related (the folder and the files within the folder) are now
> separated. And when sorting by status it means that all of the entries
> which have been modified are now together instead of being separated.
> I have added a new entry in the View menu:
> Mix folders and files
> (which would default to unchecked to preserve the current behavior)
> 
> b) Flat mode is nice, but the lack of filtering makes it less useful.
> I'm not sure if I like the filtering buttons in wincvs, so I am
> proposing a slightly different set of choices:
> I have added the following entries to the View Menu:
> Hide unmodified entries         
> (only entries that are known to be different from the repository are shown)
> Only show conflicted entries  
> (this implies and disables Hide unmodified entries option)
> 
> c) While I like using Flat mode, I always forget to reset it and thus
> having to wait a while the next time I start rapidsvn and select the
> bookmark. This is annoying if all I want to do is update.
> So, I have added a preference:
> Reset Flat Mode on exit
> When set (defaults to false), the state of flat mode is not retained
> across instantiations of rapidsvn - all bookmarks always start with flat
> mode disabled.
> 
> I added toolbar buttons for each of the new items i added to the view menu (as well \
> as a flat mode button and a show unversioned button) and for the 'reset flat mode' \
> preference. 
> These buttons behave the same as their associated view menu items and reflect the \
> setting of the option. 
> I have attached a patch file for the files i have changed and also attached the new \
> png files (and associated .h files) for the additional toolbar items i added.  
> I drew an X over the normal_file png to for the button to Hide Unchanged entries. 
> I tried to combine the normal file and normal folder icons for the 'Mix' button \
> with limited success. 
> Maybe someone with better tools or skills can draw better icons.
> 
> 
> btw: i did my builds/testing with wx msw 2.8.4 - I don't know if you were planning \
>                 on upgrading to this version or not but everything seems to work \
>                 ok.
> -jay
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@rapidsvn.tigris.org
> For additional commands, e-mail: users-help@rapidsvn.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@rapidsvn.tigris.org
For additional commands, e-mail: users-help@rapidsvn.tigris.org


[prev in list] [next in list] [prev in thread] [next in thread]