[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qubes-devel
Subject:    Re: [qubes-devel] Re: [GSoC] Qubes-MIME-Handlers Weekly Progress Report #8
From:       Jean-Philippe Ouellet <jpo () vt ! edu>
Date:       2017-08-20 19:39:12
Message-ID: CABQWM_CN0JZ-FKXJ9TEvr-z0LDTd4_8A=x8LH39S28uGZGGXEw () mail ! gmail ! com
[Download RAW message or body]

On Sun, Aug 20, 2017 at 12:54 AM, Andrew Morgan <andrew@amorgan.xyz> wrote:
> Jean-Philippe,
> 
> The top first following commits on these lists are good for code review...
> 
> https://github.com/anoadragon453/nautilus-python/commits/file_open
> https://github.com/anoadragon453/nautilus/commits/master
> 
> NOTE: There's still that crappy work-around in the second link there. It
> causes Nautilus to crash unless it's run from gdb (as gdb has 0x5555
> pre-pending all/most pointer addresses. Still not sure why the 32-bit
> truncation happens).
> 
> These files could use some review:
> 
> https://github.com/anoadragon453/qubes-mime-types/blob/master/qvm_trust.py
> https://github.com/anoadragon453/qubes-mime-types/blob/master/qubesfiletrust/qvm_file_trust.py
>  
> Still known issues:
> 
> * GDB workaround (Big blocker!)
> * update_file_info is somehow called alongside file_open by our
> extension. Likely since file_open was implemented alongside
> update_file_info in libnautilus-extension, however we never explicitly
> call it, so not sure why it's complaining about it. No known reduced
> functionality however.
> * Nautilus complains something in our extension is not actually a
> MenuItem. No known reduced functionality.
> 
> Those last couple issues aren't too relevant to the code review, but
> just wanted to note them down somewhere. :P
> 
> Thanks!
> Andrew Morgan

ACK.

Will begin reviewing offline.

Regards,
Jean-Philippe

-- 
You received this message because you are subscribed to the Google Groups \
"qubes-devel" group. To unsubscribe from this group and stop receiving emails from \
it, send an email to qubes-devel+unsubscribe@googlegroups.com. To post to this group, \
send email to qubes-devel@googlegroups.com. To view this discussion on the web visit \
https://groups.google.com/d/msgid/qubes-devel/CABQWM_CN0JZ-FKXJ9TEvr-z0LDTd4_8A%3Dx8LH39S28uGZGGXEw%40mail.gmail.com.
 For more options, visit https://groups.google.com/d/optout.


[prev in list] [next in list] [prev in thread] [next in thread]