[prev in list] [next in list] [prev in thread] [next in thread]
List: quanta-devel
Subject: Re: [quanta-devel] Review Request: Fix missing pointer indiicating
From: "Milian Wolff" <mail () milianw ! de>
Date: 2011-08-28 12:54:55
Message-ID: 20110828125455.3483.83706 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102456/#review6097
-----------------------------------------------------------
Ship it!
looks good to me
- Milian
On Aug. 27, 2011, 1:48 p.m., Florian Zumkeller-Quast wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102456/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2011, 1:48 p.m.)
>
>
> Review request for KDevelop and Quanta.
>
>
> Summary
> -------
>
> Fixes the missing pointer on the left side when stepping/debugging with xdebug
>
>
> This addresses bug 271929.
> http://bugs.kde.org/show_bug.cgi?id=271929
>
>
> Diffs
> -----
>
> debuggers/xdebug/connection.h 3f12413
> debuggers/xdebug/connection.cpp 4421b8a
> debuggers/xdebug/debugsession.cpp b051453
>
> Diff: http://git.reviewboard.kde.org/r/102456/diff
>
>
> Testing
> -------
>
> Test with a little PHP script - it did work.
>
>
> Thanks,
>
> Florian
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102456/">http://git.reviewboard.kde.org/r/102456/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">looks good to me</pre> <br />
<p>- Milian</p>
<br />
<p>On August 27th, 2011, 1:48 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2011, 1:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the missing pointer on the left side \
when stepping/debugging with xdebug</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test with a little PHP script - it did \
work.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=271929">271929</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/xdebug/connection.h <span style="color: grey">(3f12413)</span></li>
<li>debuggers/xdebug/connection.cpp <span style="color: grey">(4421b8a)</span></li>
<li>debuggers/xdebug/debugsession.cpp <span style="color: grey">(b051453)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102456/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic