[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    Re: [quanta-devel] Class Variables - no attrAutoCompleteAfter patch
From:       Andrew Lowe <andrew.lowe () manildra ! com ! au>
Date:       2007-02-17 7:41:21
Message-ID: 45D6B1A1.2060209 () manildra ! com ! au
[Download RAW message or body]

Andras Mantia wrote:

>On Friday 16 February 2007, Andras Mantia wrote:
>  
>
>>Did this work for you? It doesn't  work here and it is certainlyy not
>>your fault. I'm debugging Quanta right now, I just wanted to know if
>>it worked for you or not.
>>
>>Andras
>>    
>>
>
>Bug found & fixed. :-) I committed your patch as well, please test.
>  
>
Actually I found one problem:
Line 1342 the i++; has been moved inside the 
if(completionDTD->family==Script) statement.
I must have moved it when I moved the code that inserts tag->type into 
comments, and did not notice.

It could cause problems if we use this code is used on XML familys 
(improper numbering?) - however I do not think it is causing problems - 
I don't think XML Familys have classes?

It was actually already in inside the if statement that tests if the

I have attached a diff for you

-- 
Andrew Lowe
    System Administrator & Programmer
        Information Technology
            Manildra Group

Email:   andrew.lowe@manildra.com.au
Phone:   02 4423 8270
Mobile:  04 1323 8270
Fax:     02 4421 7760 


["update.diff" (text/plain)]

Index: src/document.cpp
===================================================================
--- src/document.cpp	(revision 634317)
+++ src/document.cpp	(working copy)
@@ -1339,8 +1339,8 @@
           comments[tagName] = tag->type + "\n" + comments[tagName];
         else
           comments[tagName] = tag->type + comments[tagName];
-        i++;
       }
+      i++;
     }
   }
 


_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel


[prev in list] [next in list] [prev in thread] [next in thread]