[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    Re: [quanta-devel] Class Variables - no attrAutoCompleteAfter patch
From:       Andras Mantia <amantia () kde ! org>
Date:       2007-02-15 15:06:24
Message-ID: 200702151706.30235.amantia () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 15 February 2007, Andrew Lowe wrote:
> You may want to autocomplete function arguments as normal variables
> ie. when you type '$', but you do not want them as class arguments
> ie. after the '->' so I would think we just need to remove the
> className?

That should already work. Actually that non-member autocompletion is 
done in a different place, in the "group" autocompletion. Normal 
variables are added to the "variable" group. The userTagsList is only 
used for members. It is kind'a hack, but that is...

> >In the completion code, I don't understand something. You set
> >
> >completion.type = type[tagNameList[i]];
> >
> >But this will be wrong for XML, as in case of XML, type is
> > unitialized. Shouldn't this be moved inside the
> >+    if(completionDTD->family==Script)
> >?
> >
> >  
>
> Yes, so it should - which incidently is what I moved from inside the
> if block, when I said I had found a mistake :-)

I looked at your second patch and here there is:
-    completions->append( completion );
+    /* Author Andrew Lowe - andrew.lowe@manildra.com.au
+     * Here we actually append the completion type
+     */
+    completion.type = type[tagNameList[i]];
+    if(completionDTD->family==Script)

So I don't understand why you think its a mistake to have that statement 
inside the if block.

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org

[Attachment #5 (application/pgp-signature)]

_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel


[prev in list] [next in list] [prev in thread] [next in thread]