[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    [quanta-devel] please review
From:       Jens Herden <jens () kdewebdev ! org>
Date:       2006-03-11 17:02:06
Message-ID: 200603120002.11998.jens () kdewebdev ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi Andras,

I looked into bug #121329 and the report is correct because Quanta does not 
reload if an open document was not modified. This is not very clever because 
the document might have changed on the server!

I attach my proposed solution. This would always reload the file and also 
prevent a message if you have a modified untitled file and try to reload this 
one. An untitled file was never reloaded, because this is impossible, but you 
got a message (if you want to save the changes) if the file was modified.

OK?

Jens

["patch-for-121329.diff" (text/x-diff)]

Index: quanta.cpp
===================================================================
--- quanta.cpp	(revision 517605)
+++ quanta.cpp	(working copy)
@@ -626,14 +626,11 @@
   if (!view)
      view = ViewManager::ref()->activeView();
   Document *w = view->document();
-  if (!w || !view->saveModified())
+  if (!w || w->isUntitled() || !view->saveModified())
       return;
-  if (!w->isUntitled() && w->isModified())
-  {
-    w->setModified(false);
-    w->openURL(w->url());
-    reparse(true);
-  }
+  w->setModified(false);
+  w->openURL(w->url());
+  reparse(true);
 }
 
 void QuantaApp::slotFileReloadAll()

[Attachment #8 (application/pgp-signature)]

_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel


[prev in list] [next in list] [prev in thread] [next in thread]