[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    Re: [quanta-devel] [patch] toggle breakpoint
From:       Linus McCabe <Linus () mccabe ! nu>
Date:       2005-02-24 20:24:17
Message-ID: 200502242124.17637.Linus () mccabe ! nu
[Download RAW message or body]


Hi

I had a quick look, comments so far:

* If you select a breakpoint in the bp-list and press delete-key, it no longer 
dissapears from the editor (but from the list). Probably because of:

@@ -63,15 +62,13 @@ int DebuggerBreakpointList::remove(Debug
       quantaApp->debugger()->UI()->deleteBreakpoint(*bp);
 
       // Remove editor markpoint if there is one...
-      quantaApp->debugger()->setMark(bp->filePath(), bp->line(), false, 
KTextEditor::MarkInterface::markType02);
+      //quantaApp->debugger()->setMark(bp->filePath(), bp->line(), false, 
KTextEditor::MarkInterface::markType02);
 
       it = m_breakpointList->remove(it);
       delete tmp;
-      count++;
+      break;
     }
   }

* the linenumbers in the bp-list and the editor are not the same - but perhaps 
it was like that already before your changes, not sure.

Except for that it seems to work great. Ill try it out a bit more while 
waiting for your comment on #1 (why did you need to commend the removal?)

/Linus

On Wednesday 23 February 2005 14.22, Thiago Silva wrote:
> -Enable toggling breakpoints through the editor icon margin
> -When lines are inserted/removed from the text, keep the breakpoints
> synchronized with the editor breakpoint marks.
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]