[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 14743] Re: scrap & rewrite memtypes handling
From:       Vincent JARDIN <vincent.jardin () 6wind ! com>
Date:       2016-02-24 6:57:33
Message-ID: 56CD545D.6030504 () 6wind ! com
[Download RAW message or body]


> this patchset replaces the 1990s-era memory allocation tracking
> with a 2010s-era memory allocation tracking.  Particularly, it
> removes the neccessity to maintain a centralised list of MTYPEs
> in the library.  Daemons can now just define their own MTYPEs on
> the fly, with per-file static scope even.
>
> The patchset is a drop-in rewrite that does _not_ require changes
> to the code making use of the allocators.  There are new
> foo_memory.[ch] files in each daemon managing the MTYPEs.
>
> To bring this to "perfection", the definitions from these files
> should wander into the individual files using them.  I did that
> only for lib/, the remainder is left as an exercise to the reader
> ;)  (Truthfully I didn't want to touch every single file in
> tree.)
>
> This patchset does NOT apply on master.  It applies on top of
> "lib: fix vrf_bitmap leak in zclient_free()".
>

LGTM, I like the mechanics of this patch. It is a nice cleanup.

Acked-by: vincent.jardin@6wind.com

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]