[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 11300] quagga/dmvpn work
From:       Timo Teras <timo.teras () iki ! fi>
Date:       2014-05-20 14:20:16
Message-ID: 20140520172016.6869e28b () vostro
[Download RAW message or body]

Hi all,

I'm writing to request review of my current quagga work, as well as
explain my plans of work for quagga to get some feedback on the
thoughts as well.

I already referred on an earlier email that I setup my quagga git tree
at: http://git.alpinelinux.org/cgit/tteras/quagga/ I plan to keep
rebasing that so that it can be fast-forward pulled whenever needed,
it's not suggested to fork it.

Please review the changes there currently. As mentioned, I'd be
interested to hear thoughts especially on the commit "bgpd: allow using
rtt in route-map's set metric".

Currently my future plans include porting opennhrp to be a quagga nhrp
module. I earlier posted about this on opennhrp mailing list already
[1]. Most of the work is fairly independent, and I'll publish testable
tree once I get to that point.

However, there's few changes to libraries/core quagga that I'd like to
do early:

1. As optimization, implement API that uses SOCK_CLOEXEC and
SOCK_NONBLOCK with socket() and accept4() where possible. This is
mostly an optimization. sockopt_socket() or similar? And define some
libzebra flags that map to SOCK_* ?

2. Move the netlink helpers from zebra to lib, and clean them up. I
remember there was discussion on using some existing library instead
(libnl, libmnl). But I'd rather not do that for the reasons that:
  a) introduction of additional dependency
  b) duplication of socket handling code that already exists in quagga
  c) they are bloated: even libmnl implements two variants of helpers
     (struct nlattr and struct nlmsghdr). single set is enough.
  d) we would need additional wrapping to integrate it to quagga
     mainloop

So I'm asking if there's any additional thoughts to this? I'm offering
to write the netlink code properly.

Thanks,
Timo

[1] http://sourceforge.net/p/opennhrp/mailman/message/32271201/

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]