[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 11290] Re: [PATCH] bgpd: bgp_fast_ext_fallover.patch
From:       David Lamparter <equinox () opensourcerouting ! org>
Date:       2014-05-19 22:25:47
Message-ID: 20140519222547.GJ602738 () jupiter ! n2 ! diac24 ! net
[Download RAW message or body]

On Tue, Sep 10, 2013 at 09:33:55PM -0700, Pradosh Mohapatra wrote:
> BGP: fix fast external fallover behavior
[...]
> 1. The patch removes the dependency on 'ifp->connected' list for fast
>    fallover. The peer already contains a nexthop structure that reflects
>    the peering address. The nexthop structure has a pointer to the
>    interface (ifp) that peering address resolves to. Everytime the TCP
>    connection succeeds, the ifp is updated. The patch uses this ifp in
>    the interface_down() callback for a match for the peers that should be
>    brought down.

Accepted - but: the failover should probably be triggered by the address
delete, not by interface-down.  When the address disappears, so does the
connectivity to the peer.

(This might make a difference when something else, like some cluster/HA
software, migrates the address to another interface for failover.  Also,
when the user deletes the address, we can also kill the sessions.)

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]