[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 10467] Re: [PATCH 1/2] [ZEBRA] Make static routes respect non-default routing tables.
From:       Joachim Nilsson <troglobit () gmail ! com>
Date:       2013-04-23 7:46:33
Message-ID: 51763C59.1010403 () gmail ! com
[Download RAW message or body]

Hi,

just found myself looking at this patch on patchwork for a
completely different reason, but the lack of symmetry with
IPv6 caught my eye. Shouldn't there be a similar construct
for the static_install_ipv6() code?

The following seems to indicate Zebra at least supports it

zebra/zebra_rib.c:rib_add_ipv6():2538
     rib->table = vrf_id;

But in zebra/zebra_rib.c:static_install_ipv6():2743 the table
is not set.

Maybe I'm trolling or just need more coffee?

Regards
  /Joachim

On 09/13/2012 08:17 PM, Scott Feldman wrote:
> [snip]
> ---
> zebra/zebra_rib.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c
> index 50674ee..b8a4703 100644
> --- a/zebra/zebra_rib.c
> +++ b/zebra/zebra_rib.c
> @@ -2036,6 +2036,7 @@ static_install_ipv4 (struct prefix *p, struct static_ipv4 *si)
>        rib->type = ZEBRA_ROUTE_STATIC;
>        rib->distance = si->distance;
>        rib->metric = 0;
> +      rib->table = zebrad.rtm_table_default;
>        rib->nexthop_num = 0;
>
>        switch (si->type)
>


_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]