[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 10227] [PATCH 5/8] zebra: warn if advertising connected with _REAL unset
From:       Christian Franke <chris () opensourcerouting ! org>
Date:       2013-01-24 15:04:47
Message-ID: 1359039890-26882-6-git-send-email-chris () opensourcerouting ! org
[Download RAW message or body]

The implementation in zebra and the zclient protocol allow to communicate
addresses to clients which are not yet in the kernel.

This is usually not done and most clients seem to expect an address to be
configured in the kernel when they receive it. Therefore, it seems
reasonable to issue a warning when advertising an address to the clients
that is not yet in the kernel.

Signed-off-by: Christian Franke <chris@opensourcerouting.org>
---
 zebra/redistribute.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/zebra/redistribute.c b/zebra/redistribute.c
index 4765824..078c2ad 100644
--- a/zebra/redistribute.c
+++ b/zebra/redistribute.c
@@ -358,6 +358,9 @@ zebra_interface_address_add_update (struct interface *ifp,
 		  p->prefixlen, ifc->ifp->name);
     }
 
+  if (!CHECK_FLAG(ifc->conf, ZEBRA_IFC_REAL))
+    zlog_warn("WARNING: advertising address to clients that is not yet usable.");
+
   router_id_add_address(ifc);
 
   for (ALL_LIST_ELEMENTS (zebrad.client_list, node, nnode, client))
-- 
1.7.10.4


_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]