[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 9591] Re: [PATCH] ospfd: avoid exhausting memory with	OSPF vertices (BZ#476)
From:       Scott Feldman <sfeldma () cumulusnetworks ! com>
Date:       2012-07-31 22:15:24
Message-ID: 72565840-4FEA-4C40-A0C2-B119D446CAEE () cumulusnetworks ! com
[Download RAW message or body]

On Jul 31, 2012, at 2:31 PM, Joakim Tjernlund wrote:

> > The topology used in testing was an NxN grid of routers.  For example, a 4x4 \
> > grid: 
> > r1
> > /\
> > /  \
> > r2  r3
> > /\  /\
> > /  \/  \
> > r4  r5  r6
> > /\  /\  /\
> > /  \/  \/  \
> > r7  r8  r9 r10
> > \  /\  /\  /
> > \/  \/  \/
> > r11 r12 r13
> > \  /\  /
> > \/  \/
> > r14 r15
> > \  /
> > \/
> > r16
> > 
> > So from root r1, r4 gets nh thru r2, r5 gets nhs thru r2/3, and r8 inherits nhs \
> > from r4 and r5, so it get 3 nhs, two of which are duplicates.  The further you \
> > get from root, the more duplication.  For this small grid, the duplicates aren't \
> > a big deal.  However, the duplicate nhs grow combinatorially, so for a larger N, \
> > say 13, you have a very large number indeed.  Enough to exhaust memory in our \
> > testing.  The patch removes the duplicates as SPF works thru the graph, so r16 \
> > above would have just the 2 nhs, not the 20 nhs without the patch. 
> It would be interesting to rerun this test with latest Quagga as the SPF code got \
> some changes.

I re-tested 13x13 with the above fix on top of your 4 SPF patches, and test PASSES.  

-scott
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev


[prev in list] [next in list] [prev in thread] [next in thread]