[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 9564] Re: [PATCH 0/4] Some SPF/unnumbered updates
From:       Paul Jakma <paul () jakma ! org>
Date:       2012-07-25 17:50:59
Message-ID: alpine.LFD.2.02.1207251844240.11085 () stoner ! jakma ! org
[Download RAW message or body]

On Thu, 19 Jul 2012, David Lamparter wrote:

> (I finally sat down and spent 2 weeks getting ospfd's SPF code into my
> head.  Now you know why I had migraines *g* - boy, is that some sh*tty
> code.  I think your patches are correct, if even conservative.  TBFH I
> had to control an urge to "rm ospf_spf.c" several times...)

The code isn't the prettiest. However, don't attribute all of the 
complexity to just the code itself. There's a lot of abstract detail in 
terms of verifying links and LSAs, that make this complex than SPF is.

Also, OSPF SPF code has to deal with semi-converged graphs. Trying to 
reason about the implications of that can be hard.

regards,
-- 
Paul Jakma	paul@jakma.org	@pjakma	Key ID: 64A2FF6A
Fortune:
Above all things, reverence yourself.
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]