[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 9419] Re: [PATCH] patchwork up & running
From:       Joakim Tjernlund <joakim.tjernlund () transmode ! se>
Date:       2012-06-08 7:15:01
Message-ID: OF592E7EAE.CCC930FD-ONC1257A17.00273E3A-C1257A17.0027D3C2 () transmode ! se
[Download RAW message or body]

Joakim Tjernlund/Transmode wrote on 2012/06/08 09:01:29:
>
> <equinox@diac24.net> wrote on 2012/06/07 19:03:32:
> >
> > On Wed, Jun 06, 2012 at 03:34:56PM +0200, Joakim Tjernlund wrote:
> > > David Lamparter <equinox@diac24.net> wrote on 2012/05/10 19:12:55:
> > > >
> > > > On Thu, May 10, 2012 at 05:22:05PM +0200, Joakim Tjernlund wrote:
> > > > > Cool, I hope you are basing this off my old patches?
> > > >
> > > > Yes, I am.  Actually it's kind of a 3-way merge; your code, code from a
> > > > sponsor, and some changes of my own.  I'm discussing it with the sponsor
> > > > tomorrow and will post it to -dev for comments after we've merged our
> > > > ideas/opinions.
> > >
> > > Anything to show yet?
> > > I stumbled on the unnumbered branch at opensourcerouting.org, from a quick look
> > > I must say that I don't agree with them, especially the SPF one. That one looks
> > > like it is based on some old patch of mine that wasn't the solution in the end.

Found my old patch(http://patchwork.quagga.net/patch/268/).
This looks very similar to what is in
 https://github.com/opensourcerouting/quagga/commit/bd377461beecb2156cf3e8c3443381fe0e8d7d64

My patch description has the disadvantages of doing it this way:
Add support for real unnumbered PtP interfaces in
ospf_nexthop_calculation().
Add ospf_if_lookup_by_ifindex() to support Unnumbered
PtP links. This version does not support:
 - Multiple numbered PtP interfaces with the same IP address
   between the same two routers.
 - Unnumbered PtP on just one end of the link.


> >
> > We're just coming about on a lengthy discussion about how to handle the
> > actual ddress selection and configuration.  We didn't quite know our own
> > opinion, so this discussion happened non-publicly.  I'll give a short
> > summary and invite comments soon.
> >
> > On the SPF code, can you give me a pointer to your current code?  I'd
> > like to address your feedback, but I kinda need you to be a little more
> > constructive here :)
>
> Here is the SPF one
> http://patchwork.quagga.net/patch/263/

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]