[prev in list] [next in list] [prev in thread] [next in thread]
List: quagga-dev
Subject: [quagga-dev 8353] Re: [PATCH 4/7] ospf6d: Extend the "[no] debug
From: Balaji G <balajig81 () gmail ! com>
Date: 2010-11-16 5:57:22
Message-ID: AANLkTimzp9eEjkNWf0Sd+F8uo_V-p4ZTY07hKTXP-6zq () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Tom
Am not sure whether we need to display "memory" option in the CLI, probably
might not be useful for the end users.
Probably Greg could comment
Cheers,
- Balaji
On Thu, Nov 11, 2010 at 2:32 AM, Tom Goff <thomas.goff@boeing.com> wrote:
> * ospf6_route.c ([no_]debug_ospf6_route) Include memory as a debug
> option. This allows ospf6 route memory debugging to be enabled or
> disabled interactively or from a config file.
>
> Signed-off-by: Tom Goff <thomas.goff@boeing.com>
> ---
> ospf6d/ospf6_route.c | 12 +++++++++---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/ospf6d/ospf6_route.c b/ospf6d/ospf6_route.c
> index 1e1f4fb..2d02710 100644
> --- a/ospf6d/ospf6_route.c
> +++ b/ospf6d/ospf6_route.c
> @@ -1335,13 +1335,14 @@ ospf6_brouter_show (struct vty *vty, struct
> ospf6_route *route)
>
> DEFUN (debug_ospf6_route,
> debug_ospf6_route_cmd,
> - "debug ospf6 route (table|intra-area|inter-area)",
> + "debug ospf6 route (table|intra-area|inter-area|memory)",
> DEBUG_STR
> OSPF6_STR
> "Debug route table calculation\n"
> "Debug detail\n"
> "Debug intra-area route calculation\n"
> "Debug inter-area route calculation\n"
> + "Debug route memory use\n"
> )
> {
> unsigned char level = 0;
> @@ -1352,18 +1353,21 @@ DEFUN (debug_ospf6_route,
> level = OSPF6_DEBUG_ROUTE_INTRA;
> else if (! strncmp (argv[0], "inter", 5))
> level = OSPF6_DEBUG_ROUTE_INTER;
> + else if (! strncmp (argv[0], "memor", 5))
> + level = OSPF6_DEBUG_ROUTE_MEMORY;
> OSPF6_DEBUG_ROUTE_ON (level);
> return CMD_SUCCESS;
> }
>
> DEFUN (no_debug_ospf6_route,
> no_debug_ospf6_route_cmd,
> - "no debug ospf6 route (table|intra-area|inter-area)",
> + "no debug ospf6 route (table|intra-area|inter-area|memory)",
> NO_STR
> DEBUG_STR
> OSPF6_STR
> "Debug route table calculation\n"
> - "Debug intra-area route calculation\n")
> + "Debug intra-area route calculation\n"
> + "Debug route memory use\n")
> {
> unsigned char level = 0;
>
> @@ -1373,6 +1377,8 @@ DEFUN (no_debug_ospf6_route,
> level = OSPF6_DEBUG_ROUTE_INTRA;
> else if (! strncmp (argv[0], "inter", 5))
> level = OSPF6_DEBUG_ROUTE_INTER;
> + else if (! strncmp (argv[0], "memor", 5))
> + level = OSPF6_DEBUG_ROUTE_MEMORY;
> OSPF6_DEBUG_ROUTE_OFF (level);
> return CMD_SUCCESS;
> }
> --
> 1.7.0.4
>
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev@lists.quagga.net
> http://lists.quagga.net/mailman/listinfo/quagga-dev
>
[Attachment #5 (text/html)]
<div>Hi Tom </div><div><br></div>Am not sure whether we need to display \
"memory" option in the CLI, probably might not be useful for the end users. \
<div>Probably Greg could comment<br><div><br></div><div>Cheers,</div> <div> - \
Balaji</div><div><br><br><div class="gmail_quote">On Thu, Nov 11, 2010 at 2:32 AM, \
Tom Goff <span dir="ltr"><<a \
href="mailto:thomas.goff@boeing.com">thomas.goff@boeing.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">
* ospf6_route.c ([no_]debug_ospf6_route) Include memory as a debug<br>
option. This allows ospf6 route memory debugging to be enabled or<br>
disabled interactively or from a config file.<br>
<br>
Signed-off-by: Tom Goff <<a \
href="mailto:thomas.goff@boeing.com">thomas.goff@boeing.com</a>><br>
---<br>
ospf6d/ospf6_route.c | 12 +++++++++---<br>
1 files changed, 9 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/ospf6d/ospf6_route.c b/ospf6d/ospf6_route.c<br>
index 1e1f4fb..2d02710 100644<br>
--- a/ospf6d/ospf6_route.c<br>
+++ b/ospf6d/ospf6_route.c<br>
@@ -1335,13 +1335,14 @@ ospf6_brouter_show (struct vty *vty, struct ospf6_route \
*route)<br> <br>
DEFUN (debug_ospf6_route,<br>
debug_ospf6_route_cmd,<br>
- "debug ospf6 route (table|intra-area|inter-area)",<br>
+ "debug ospf6 route (table|intra-area|inter-area|memory)",<br>
DEBUG_STR<br>
OSPF6_STR<br>
"Debug route table calculation\n"<br>
"Debug detail\n"<br>
"Debug intra-area route calculation\n"<br>
"Debug inter-area route calculation\n"<br>
+ "Debug route memory use\n"<br>
)<br>
{<br>
unsigned char level = 0;<br>
@@ -1352,18 +1353,21 @@ DEFUN (debug_ospf6_route,<br>
level = OSPF6_DEBUG_ROUTE_INTRA;<br>
else if (! strncmp (argv[0], "inter", 5))<br>
level = OSPF6_DEBUG_ROUTE_INTER;<br>
+ else if (! strncmp (argv[0], "memor", 5))<br>
+ level = OSPF6_DEBUG_ROUTE_MEMORY;<br>
OSPF6_DEBUG_ROUTE_ON (level);<br>
return CMD_SUCCESS;<br>
}<br>
<br>
DEFUN (no_debug_ospf6_route,<br>
no_debug_ospf6_route_cmd,<br>
- "no debug ospf6 route (table|intra-area|inter-area)",<br>
+ "no debug ospf6 route (table|intra-area|inter-area|memory)",<br>
NO_STR<br>
DEBUG_STR<br>
OSPF6_STR<br>
"Debug route table calculation\n"<br>
- "Debug intra-area route calculation\n")<br>
+ "Debug intra-area route calculation\n"<br>
+ "Debug route memory use\n")<br>
{<br>
unsigned char level = 0;<br>
<br>
@@ -1373,6 +1377,8 @@ DEFUN (no_debug_ospf6_route,<br>
level = OSPF6_DEBUG_ROUTE_INTRA;<br>
else if (! strncmp (argv[0], "inter", 5))<br>
level = OSPF6_DEBUG_ROUTE_INTER;<br>
+ else if (! strncmp (argv[0], "memor", 5))<br>
+ level = OSPF6_DEBUG_ROUTE_MEMORY;<br>
OSPF6_DEBUG_ROUTE_OFF (level);<br>
return CMD_SUCCESS;<br>
}<br>
<font color="#888888">--<br>
1.7.0.4<br>
<br>
_______________________________________________<br>
Quagga-dev mailing list<br>
<a href="mailto:Quagga-dev@lists.quagga.net">Quagga-dev@lists.quagga.net</a><br>
<a href="http://lists.quagga.net/mailman/listinfo/quagga-dev" \
target="_blank">http://lists.quagga.net/mailman/listinfo/quagga-dev</a><br> \
</font></blockquote></div><br></div></div>
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic