[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 5505] Re: [PATCH] bgp: fix double free in route server
From:       paul () clubi ! ie
Date:       2008-06-17 9:59:29
Message-ID: alpine.LFD.1.10.0806171057050.7631 () localhost ! localdomain
[Download RAW message or body]

On Mon, 16 Jun 2008, Stephen Hemminger wrote:

> Deleting a neighbor with route server client results in double free
> of bgp_table.  The fix is to just null the entry after freeing as per
> other allocations in BGP.

> Probably fixes http://bugzilla.quagga.net/show_bug.cgi?id=410

Ah, well spotted.

Could you make bgp_table_finish take a double-pointer, and have it 
set the freed field to NULL there instead?

Probably should make that a general style rule for free-like 
functions..

regards,
-- 
Paul Jakma	paul@clubi.ie	paul@jakma.org	Key ID: 64A2FF6A
 	http://www.quagga.net/commercial.php#jakma
Fortune:
Thank you for observing all safety precautions.
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]