[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 5250] Re: [PATCH] include quagga headers in C++
From:       "Peter Szilagyi" <sp615 () hszk ! bme ! hu>
Date:       2008-01-31 13:16:24
Message-ID: e9637ddc0801310516s2ab47496gd3324bfa80ca21fc () mail ! gmail ! com
[Download RAW message or body]

On Jan 31, 2008 12:45 PM,  <paul@clubi.ie> wrote:
> On Thu, 31 Jan 2008, Peter Szilagyi wrote:
>
> > I kept the naming here so that it remains clear which parameter is
> > the source and which is the target when copying streams.
>
> Indeed, a poor attempt at documentation.

I agree, but I did not intend to change things more than it was
necessary to get C++ linkage working. Quality of documentation is
another question.

> Well, I wouldn't have thought there were many users of outside of the
> Quagga sources interested in libzebra, due to lack of seperation and
> various bits of cruft.
>
> However, if there are, then adding the #ifdef...extern "C" stuff
> seems an idea. It'd be nice to get (what is today) libzebra cleaned
> up enough to externally useable - as this would (almost) imply that
> the daemons could be packaged seperately. There's a lot more involved
> than just the C++ extern though.

What I did is fixing C++ linkage utilizing the possible minimum
changes in quagga code. Presumably there would be much more to do like
better separation of daemons, but that's out of my personal interest
and far beyond my knowledge of quagga/zebra internals.

> What benefit do you get Obviously, you've already taken care of the
> problem inside your own code, but what benefit do you get form
> libzebra?

I simply would like to use the ospf api from C++ code, so I had to
link against libzebra, libospf and libospfapiclient. It may not be
necessary to link against all these, but it seemed to be a
straightforward step.

Regards,
Peter
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]