[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qmail-ldap
Subject:    Re: qmailgroup problem with moderation and senderconfirm
From:       Claudio Jeker <jeker () n-r-g ! com>
Date:       2004-11-15 10:52:13
Message-ID: 20041115105201.GA19479 () diehard ! n-r-g ! com
[Download RAW message or body]

On Wed, Nov 10, 2004 at 08:53:14AM +0100, Claudio Jeker wrote:
> On Wed, Nov 10, 2004 at 09:26:36AM +0200, George Lekatsas wrote:
> > Hello,
> > 

<SNIP>

> > 
> > Moderation without senderconfirm is working.
> > Senderconfirm without moderation is working too.
> > 
> 
> It could be that the moderation approval and the senderconfirmation need
> to be sent by two different accounts. This seems to be a bug.
> Will have a look at it later today.
> 

Took a little longer but here is a fix for this problem.

-- 
:wq Claudio

Index: qmail-group.c
===================================================================
RCS file: /home/cvs-djbware/CVS/qmail-ldap/qmail-group.c,v
retrieving revision 1.15
diff -u -p -r1.15 qmail-group.c
--- qmail-group.c	11 Jun 2004 12:58:09 -0000	1.15
+++ qmail-group.c	15 Nov 2004 10:59:46 -0000
@@ -132,6 +132,7 @@ main(int argc, char **argv)
 	if (flagm)
 		secretary(maildir, 1);
 
+	reopen();
 	explode(qlc);
 	qldap_free(qlc);
 	
@@ -309,6 +310,8 @@ reopen(void)
 {
 	int fd;
 
+	if (!(fname.s && fname.len > 1))
+		return;
 	if (!stralloc_0(&fname)) temp_nomem();
 	fd = open_read(fname.s);
 	if (fd == -1)
@@ -413,7 +416,6 @@ secretary(char *maildir, int flagmoderat
 			if (!stralloc_append(&fname, &sbuf[i])) temp_nomem();
 		}
 		close(pi[0]);
-		reopen();
 		return;
 	default: _exit(111);
 	}
[prev in list] [next in list] [prev in thread] [next in thread]