[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qgis-developer
Subject:    Re: [Qgis-developer] Point releases
From:       Nyall Dawson <nyall.dawson () gmail ! com>
Date:       2015-11-25 21:33:59
Message-ID: CAB28AsgBAXOL5GG4n6-qCb0EiYziRDG1YiXbbDGbzTyyxmCkQw () mail ! gmail ! com
[Download RAW message or body]

On 26 November 2015 at 07:51, Luigi Pirelli <luipir@gmail.com> wrote:
> ok, I can remove pull request regarding FTool message
>
> wonderful team work... we can summarize some "lesson learned" from this bug?

Write unit tests for critical stuff like this? Don't accept a
replacement for ftools which isn't accompanied by extensive unit
testing? ;)

I'm honestly not sure there is any other solution to avoid this in
future. The bugs were present for a number of releases, so had already
been exposed to extensive USER testing. User testing alone obviously
wasn't enough in this case.

A good regression test suite could have flagged these regressions when
the breaking commits landed. The motivation would then have been on
the developer who broke the tests to fix the regressions or suffer the
wrath of Travis ;)

(BTW, just so we're clear... ftools is old and predated QGIS' current
CI testing infrastructure. I'm not blaming anyone for not having unit
tests for ftools or for breaking the crufty old code in that plugin. I
just think that moving forward any replacement for ftools MUST have a
extensive unit test suite, that's all).

Nyall



>
> cheers
> Luigi Pirelli
>
> **************************************************************************************************
> * Boundless QGIS Support/Development: lpirelli AT boundlessgeo DOT com
> * LinkedIn: https://www.linkedin.com/in/luigipirelli
> * Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli
> * GitHub: https://github.com/luipir
> * Mastering QGIS:
> https://www.packtpub.com/application-development/mastering-qgis
> **************************************************************************************************
>
>
> On 25 November 2015 at 17:15, DelazJ <delazj@gmail.com> wrote:
>> +1 for the point release. And one release a month as scheduled seems
>> reasonable to me. But since every user can not download and install each
>> release, it'll be worth listing the bugs that are fixed. So the user can
>> clearly evaluate if it's worth updating QGIS according to his needs.
>>
>> 2015-11-25 14:12 GMT+01:00 Anita Graser <anitagraser@gmx.at>:
>>>
>>>
>>>
>>> On Wed, Nov 25, 2015 at 12:31 PM, Paolo Cavallini <cavallini@faunalia.it>
>>> wrote:
>>>>
>>>> Il 25/11/2015 12:28, Werner Macho ha scritto:
>>>>
>>>> > According to my tests with Intersect and Union the ftools problem is
>>>> > fixed now .. so this only "leaves" 2.10 without a fix -  which we
>>>> > apperently don't need (people using 2.10 should upgrade to 2.12
>>>> > anyway)..
>>>> >
>>>> > Well done!
>>>>
>>>> What a relief, thanks Marco, Werner, Juergen, and all!
>>>> Probably we should advertise this, and suggest everybody to upgrade
>>>> immediately.
>>>>
>>>
>>> +1 a big shout out for the new point release is definitely in order.
>>>
>>> Thanks for the fixes and I also think a point release schedule is helpful.
>>>
>>> Best wishes,
>>> Anita
>>>
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Qgis-developer mailing list
>>> Qgis-developer@lists.osgeo.org
>>> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>>> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>>
>>
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer@lists.osgeo.org
>> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
_______________________________________________
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
[prev in list] [next in list] [prev in thread] [next in thread]