[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-s390x
Subject:    Re: [PATCH 4/5] target/s390x: Restrict sysemu/reset.h to system emulation
From:       Thomas Huth <thuth () redhat ! com>
Date:       2022-12-29 9:45:48
Message-ID: a9c9232e-5912-b4da-face-d9d2ee376b36 () redhat ! com
[Download RAW message or body]

On 20/12/2022 15.56, Philippe Mathieu-Daudé wrote:
> In user emulation, threads -- implemented as CPU -- are
> created/destroyed, but never reset. There is no point in
> allowing the user emulation access the sysemu/reset API.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/s390x/cpu.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
> index 96562c516d..b10a8541ff 100644
> --- a/target/s390x/cpu.c
> +++ b/target/s390x/cpu.c
> @@ -26,7 +26,6 @@
>   #include "s390x-internal.h"
>   #include "kvm/kvm_s390x.h"
>   #include "sysemu/kvm.h"
> -#include "sysemu/reset.h"
>   #include "qemu/module.h"
>   #include "trace.h"
>   #include "qapi/qapi-types-machine.h"
> @@ -35,6 +34,9 @@
>   #include "fpu/softfloat-helpers.h"
>   #include "disas/capstone.h"
>   #include "sysemu/tcg.h"
> +#ifndef CONFIG_USER_ONLY
> +#include "sysemu/reset.h"
> +#endif
>   
>   #define CR0_RESET       0xE0UL
>   #define CR14_RESET      0xC2000000UL;

Reviewed-by: Thomas Huth <thuth@redhat.com>


[prev in list] [next in list] [prev in thread] [next in thread]