[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-s390x
Subject:    Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices
From:       Markus Armbruster <armbru () redhat ! com>
Date:       2020-05-29 13:45:26
Message-ID: 87ftbilurt.fsf () dusky ! pond ! sub ! org
[Download RAW message or body]

Markus Armbruster <armbru@redhat.com> writes:

> David Hildenbrand <david@redhat.com> writes:
>
>>>> +static void realize_event_facility(DeviceState *dev, Error **errp)
>>>> +{
>>>> +    SCLPEventFacility *event_facility = EVENT_FACILITY(dev);
>>>> +    Error *local_err = NULL;
>>>> +
>>>> +    qdev_realize(DEVICE(&event_facility->quiesce),
>>>> +                 BUS(&event_facility->sbus), &local_err);
>>>> +    if (local_err) {
>>>> +        error_propagate(errp, local_err);
>>>> +        return;
>>>> +    }
>>>> +    qdev_realize(DEVICE(&event_facility->cpu_hotplug),
>>>> +                 BUS(&event_facility->sbus), errp);
>>> 
>>> Just wondering, do we have to care about un-realizing quiesce in case
>>> this fails?
>>
>> Just remembered that we fail creating the machine and therefore abort. So not necessary :)
>
> True.

I chose to clean up on error anyway in v2.  Thanks!



[prev in list] [next in list] [prev in thread] [next in thread]