[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-riscv
Subject:    Re: [Qemu-riscv] [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of in
From:       Aleksandar Markovic <aleksandar.m.mail () gmail ! com>
Date:       2019-04-25 5:31:49
Message-ID: CAL1e-=gTwNJ94-ZdhPZR_THAi_TfiToox0KrxLZnhARbjUKLxw () mail ! gmail ! com
[Download RAW message or body]

On Apr 25, 2019 7:17 AM, "Richard Henderson" <richard.henderson@linaro.org>
wrote:
>
> On 4/24/19 8:31 PM, Palmer Dabbelt wrote:
> >>  # Argument sets:
> >> +&empty
> >
> > If I understand decodetree correctly, this isn't used until patch 5.
> > Otherwise,
> >
>
> I think it's used as early as patch 3, but I haven't looked in detail to
be sure.
>
>
> r~
>

I think it is a very bad practice to leave the commit message empty, and,
in my view, the long-time contributor, like you, Richard, have the
obligation to always give examples of commit messages of good quality.
Leaving empty commit messages should not be a "privelage" that comes with
seniority, IMHO. On the contrary.

Sincerely,
Aleksandar

[Attachment #3 (text/html)]

<p dir="ltr"><br>
On Apr 25, 2019 7:17 AM, &quot;Richard Henderson&quot; &lt;<a \
href="mailto:richard.henderson@linaro.org">richard.henderson@linaro.org</a>&gt; \
wrote:<br> &gt;<br>
&gt; On 4/24/19 8:31 PM, Palmer Dabbelt wrote:<br>
&gt; &gt;&gt;   # Argument sets:<br>
&gt; &gt;&gt; +&amp;empty<br>
&gt; &gt; <br>
&gt; &gt; If I understand decodetree correctly, this isn&#39;t used until patch \
5.<br> &gt; &gt; Otherwise,<br>
&gt; &gt; <br>
&gt;<br>
&gt; I think it&#39;s used as early as patch 3, but I haven&#39;t looked in detail to \
be sure.<br> &gt;<br>
&gt;<br>
&gt; r~<br>
&gt;</p>
<p dir="ltr">I think it is a very bad practice to leave the commit message empty, \
and, in my view, the long-time contributor, like you, Richard, have the obligation to \
always give examples of commit messages of good quality. Leaving empty commit \
messages should not be a "privelage" that comes with seniority, IMHO. On the \
contrary.</p> <p dir="ltr">Sincerely,<br>
Aleksandar<br>
</p>



[prev in list] [next in list] [prev in thread] [next in thread]