[prev in list] [next in list] [prev in thread] [next in thread]
List: qemu-ppc
Subject: Re: [RFC PATCH v2 09/29] target/ppc: remove generic architecture checks from p9_deliver_interrupt
From: Fabiano Rosas <farosas () linux ! ibm ! com>
Date: 2022-09-30 18:13:32
Message-ID: 87r0zs688j.fsf () linux ! ibm ! com
[Download RAW message or body]
Matheus Ferst <matheus.ferst@eldorado.org.br> writes:
> No functional change intended.
>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> ---
> target/ppc/excp_helper.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 603c956588..67e73f30ab 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -1919,18 +1919,11 @@ static void p9_deliver_interrupt(CPUPPCState *env, int interrupt)
> break;
>
> case PPC_INTERRUPT_DECR: /* Decrementer exception */
> - if (ppc_decr_clear_on_delivery(env)) {
> - env->pending_interrupts &= ~PPC_INTERRUPT_DECR;
> - }
Maybe I'm missing something, but this should continue to clear the bit,
no? Same comment for P8.
> powerpc_excp(cpu, POWERPC_EXCP_DECR);
> break;
> case PPC_INTERRUPT_DOORBELL:
> env->pending_interrupts &= ~PPC_INTERRUPT_DOORBELL;
> - if (is_book3s_arch2x(env)) {
> - powerpc_excp(cpu, POWERPC_EXCP_SDOOR);
> - } else {
> - powerpc_excp(cpu, POWERPC_EXCP_DOORI);
> - }
> + powerpc_excp(cpu, POWERPC_EXCP_SDOOR);
> break;
> case PPC_INTERRUPT_HDOORBELL:
> env->pending_interrupts &= ~PPC_INTERRUPT_HDOORBELL;
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic