[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-ppc
Subject:    Re: [PATCH v6 20/33] block: rename bdrv_invalidate_cache_all, blk_invalidate_cache and test_sync_op_
From:       Paolo Bonzini <pbonzini () redhat ! com>
Date:       2022-01-31 15:59:57
Message-ID: dae7ed3d-5e25-7075-96fd-3a059c8e7b2c () redhat ! com
[Download RAW message or body]

On 1/27/22 10:18, Emanuele Giuseppe Esposito wrote:
>>>           /* Make sure all file formats flush their mutable metadata.
>>>            * If we get an error here, just don't restart the VM yet. */
>>> -        bdrv_invalidate_cache_all(&local_err);
>>> +        bdrv_activate_all(&local_err);
>> I guess that we can change the comment here, it just looks weird the
>> comment saying flush() and the function nawed _activate()
>>
> Do you think it's enough to replace "flush" with "activate"? I am not
> sure whether "activate their mutable metadata" is meaningful.

"Activation" consists of throwing away mutable metadata.

That's what "flush" means in this case, but it is often interpreted as 
"persisting" the metadata instead.  So perhaps s/flush/throw away/.

Paolo

[prev in list] [next in list] [prev in thread] [next in thread]