[prev in list] [next in list] [prev in thread] [next in thread]
List: qemu-ppc
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/14] target/ppc: remove getVSR()/putVSR() from int_helper.c
From: Richard Henderson <richard.henderson () linaro ! org>
Date: 2019-04-30 16:32:44
Message-ID: 3df9625c-2d66-82f8-119f-61af3bfc1f86 () linaro ! org
[Download RAW message or body]
On 4/28/19 7:38 AM, Mark Cave-Ayland wrote:
> void helper_xxextractuw(CPUPPCState *env, target_ulong xtn,
> target_ulong xbn, uint32_t index)
> {
> - ppc_vsr_t xt, xb;
> + ppc_vsr_t *xt = &env->vsr[xtn];
> + ppc_vsr_t *xb = &env->vsr[xbn];
> size_t es = sizeof(uint32_t);
> uint32_t ext_index;
> int i;
>
> - getVSR(xbn, &xb, env);
> - memset(&xt, 0, sizeof(xt));
> + memset(xt, 0, sizeof(ppc_vsr_t));
This fails if xt == xb.
Similarly for xxinsertw.
r~
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic