[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-ppc
Subject:    Re: [Qemu-ppc] [PATCH] spapr: refresh "platform-specific" hcalls comment
From:       Thomas Huth <thuth () redhat ! com>
Date:       2017-06-30 10:30:00
Message-ID: 74e3d68d-d7b0-a3f2-c798-056d6b405740 () redhat ! com
[Download RAW message or body]

On 30.06.2017 12:05, Greg Kurz wrote:
> We have more of these since the addition of KVMPPC_H_LOGICAL_MEMOP in 2012.

Right, and we don't need one for virtio :-)

> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  include/hw/ppc/spapr.h |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> index a66bbac35242..1826cc4fd696 100644
> --- a/include/hw/ppc/spapr.h
> +++ b/include/hw/ppc/spapr.h
> @@ -377,9 +377,8 @@ struct sPAPRMachineState {
>   * as well.
>   *
>   * We also need some hcalls which are specific to qemu / KVM-on-POWER.
> - * So far we just need one for H_RTAS, but in future we'll need more
> - * for extensions like virtio.  We put those into the 0xf000-0xfffc
> - * range which is reserved by PAPR for "platform-specific" hcalls.
> + * We put those into the 0xf000-0xfffc range which is reserved by PAPR
> + * for "platform-specific" hcalls.
>   */
>  #define KVMPPC_HCALL_BASE       0xf000
>  #define KVMPPC_H_RTAS           (KVMPPC_HCALL_BASE + 0x0)

Reviewed-by: Thomas Huth <thuth@redhat.com>


[prev in list] [next in list] [prev in thread] [next in thread]