[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-ppc
Subject:    Re: [Qemu-ppc] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sysbus devices
From:       Peter Maydell <peter.maydell () linaro ! org>
Date:       2014-07-30 14:55:56
Message-ID: CAFEAcA8vzCFzb_b7LyRhL9Nw8w=sGh9Y8=cVQNHZbNSPVcLNRg () mail ! gmail ! com
[Download RAW message or body]

On 2 July 2014 19:01, Alexander Graf <agraf@suse.de> wrote:
> For e500 our approach to supporting dynamically spawned sysbus devices is to
> create a simple bus from the guest's point of view within which we map those
> devices dynamically.
>
> +    /* Connect sysbus device to virtual platform bus */
> +    for (i = 0; i < sbdev->num_irq; i++) {
> +        if (!sbdev->irqp[i]) {
> +            /* This IRQ is an incoming IRQ, we can't wire those here */

I don't understand this comment -- sysbus IRQs are all outbound
by definition. Lines going in to a device are GPIOs. (Ideally we
should get rid of "sysbus IRQs" completely and just use named
inbound GPIOs for everything.)

Also, sbdev->irqp[] is private to the sysbus implementation, so
you shouldn't be fishing about in it in the platform code.

thanks
-- PMM


[prev in list] [next in list] [prev in thread] [next in thread]