[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-ppc
Subject:    Re: [Qemu-ppc] [Qemu-devel] [V3 PATCH 04/14] target-ppc: Add ISA2.06 divde[o] Instructions
From:       Richard Henderson <rth () twiddle ! net>
Date:       2013-12-24 15:22:25
Message-ID: 52B9A6B1.7050900 () twiddle ! net
[Download RAW message or body]

On 12/18/2013 12:48 PM, Tom Musta wrote:
> +        *plow = result;
> +        *phigh = dividend % divisor;
> +        return (result > INT64_MAX) | (result < INT64_MIN);

Probably better as

  return result != *plow;

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~


[prev in list] [next in list] [prev in thread] [next in thread]