[prev in list] [next in list] [prev in thread] [next in thread]
List: qemu-devel
Subject: Re: [PATCH v2 08/45] target/hppa: Add install_link
From: Helge Deller <deller () gmx ! de>
Date: 2024-05-14 15:43:00
Message-ID: 69962579-43d1-4611-9606-0753dfc2d24c () gmx ! de
[Download RAW message or body]
On 5/14/24 16:37, Helge Deller wrote:
> * Richard Henderson <richard.henderson@linaro.org>:
>> Add a common routine for writing the return address.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Reviewed-by: Helge Deller <deller@gmx.de>
>
>> ---
>> target/hppa/translate.c | 54 +++++++++++++++++++++++------------------
>> 1 file changed, 31 insertions(+), 23 deletions(-)
>>
>> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
>> index 08d5e2a4bc..f816b337ee 100644
>> --- a/target/hppa/translate.c
>> +++ b/target/hppa/translate.c
>> @@ -634,6 +634,23 @@ static void install_iaq_entries(DisasContext *ctx, uint64_t bi, TCGv_i64 bv,
>> }
>> }
>>
>> +static void install_link(DisasContext *ctx, unsigned link, bool with_sr0)
>> +{
>> + tcg_debug_assert(ctx->null_cond.c == TCG_COND_NEVER);
>> + if (link) {
>
> Just wondering:
> Doesn't it makes it easier to write here:
> if (!link) {
> return;
> }
> and then don't indent the few following lines?
I see you change and partly revert it again in patch #17...
so forget this remark for now.
Helge
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic